Use strncpy as proposed by Hilko Bengen in PR VirusTotal#314

It does the same but is more compact and elegant.
1sn0m4d · Jul 30, 2015 · 14dbf62 · 14dbf62
1 parent 6ad1182
commit 14dbf62
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/libyara/modules/pe.c b/libyara/modules/pe.c
@@ -1304,12 +1304,8 @@ void pe_parse_header(
     if (!struct_fits_in_pe(pe, section, IMAGE_SECTION_HEADER))
       break;
 
-    int n = 0;
-
-    for (; n < IMAGE_SIZEOF_SHORT_NAME && section->Name[n]; n++)
-      section_name[n] = section->Name[n];
-
-    section_name[n] = '\0';
+    strncpy(section_name, (char*) section->Name, IMAGE_SIZEOF_SHORT_NAME);
+    section_name[IMAGE_SIZEOF_SHORT_NAME] = '\0';
 
     set_string(
         section_name,