[SYS] Fix ESP8266 discovery publications #2100
Merged
+9
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1technophile
force-pushed
the
fix-esp8266-restarts
branch
from
7b13e5d to
a5ad8e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Before this PR discovery messages at start were not published with ESP8266 due to memory, this PR fixes it.
Also we don't need to use
JSON_MSG_BUFFER_MAXwith ESP32 into discovery messages as we have now a base of1024withJSON_MSG_BUFFERwhich is more than the requirement for the cover discovery messageChecklist: