Allow configuration of CC1101 SPI pins #2141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If all CC1101 SPI pins are defined, use them to create the SPI device. Otherwise, default to the platform's SPI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If all CC1101 SPI pins are defined, use them to create the SPI device. Otherwise, default to the platform's SPI.
Description:
The ELECHOUSE_cc1101 library is responsible for setting up the SPI device for the CC1101. Using anything other than the default VSPI for the platform requires calling setSpiPin() before getCC1101(). I tested this on my Lolin D32 which shares the onboard LED with the VSPI CS pin, hence the desire to switch pins. If desired, I can open another PR to add the board config as well.
Checklist: