refactor: 즐겨찾기 N+1 문제해결

2024-Hanium-PlanDing · Sep 19, 2024 · 824820c · 824820c
1 parent 1d04b51
commit 824820c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/...n/java/com/tukorea/planding/domain/group/repository/favorite/GroupFavoriteRepository.java b/...n/java/com/tukorea/planding/domain/group/repository/favorite/GroupFavoriteRepository.java
@@ -17,4 +17,7 @@ public interface GroupFavoriteRepository extends JpaRepository<GroupFavorite, Lo
     @Transactional
     @Query("DELETE FROM GroupFavorite gf WHERE gf.user.id = :userId AND gf.groupRoom.groupCode = :groupCode")
     void deleteByUserIdAndGroupRoomId(@Param("userId") Long userId, @Param("groupCode") String groupCode);
+
+    @Query("SELECT gf FROM GroupFavorite gf JOIN FETCH gf.groupRoom WHERE gf.user.id = :userId")
+    List<GroupFavorite> findFavoriteGroupsByUser(Long userId);
 }
diff --git a/src/main/java/com/tukorea/planding/domain/group/service/GroupFavoriteService.java b/src/main/java/com/tukorea/planding/domain/group/service/GroupFavoriteService.java
@@ -30,10 +30,10 @@ public class GroupFavoriteService {
     private final UserQueryService userQueryService;
     private final GroupQueryService groupQueryService;
 
+
     @Transactional(readOnly = true)
     public List<GroupResponse> findFavoriteGroupsByUser(UserInfo userInfo) {
-        return userQueryService.getUserByUserCode(userInfo.getUserCode())
-                .getGroupFavorites()
+        return groupFavoriteRepository.findFavoriteGroupsByUser(userInfo.getId())
                 .stream()
                 .map(GroupFavorite::getGroupRoom)
                 .map(GroupResponse::from)