Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to internal bounding box type. #24

Merged
merged 2 commits into from
May 18, 2020
Merged

Switch to internal bounding box type. #24

merged 2 commits into from
May 18, 2020

Conversation

sayrer
Copy link
Contributor

@sayrer sayrer commented May 11, 2020

Another way of fixing #16.

bluenote10
bluenote10 reviewed May 11, 2020
View reviewed changes
lib/src/boolean/mod.rs Outdated Show resolved Hide resolved
@bluenote10
Copy link
Contributor

That's basically what I had in mind. Minor notes:

  • We probably should bump the version to 0.3 to satisfy semver.
  • Perhaps I wouldn't have placed the helper type directly in mod.rs but maybe its own module or somewhere in the helpers or so.

@sayrer
Copy link
Contributor Author

sayrer commented May 16, 2020

@bluenote10 is this good enough to merge?

@bluenote10
Copy link
Contributor

Yes, this looks good to me, thanks for the changes. I just don't have merge rights, let's ping @untoldwind.

@nick-parker nick-parker mentioned this pull request May 17, 2020
Open
@untoldwind untoldwind merged commit dd6efa6 into 21re:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluenote10 bluenote10 bluenote10 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sayrer @bluenote10 @untoldwind