Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support to new version vmess link #516

Merged
merged 3 commits into from
Jul 25, 2020
Merged

add support to new version vmess link #516

merged 3 commits into from
Jul 25, 2020

Conversation

iseki0
Copy link
Contributor

@iseki0 iseki0 commented Jul 22, 2020

some information can be found at: v2ray/discussion#720

}
"quic" -> {
vmess.network = "quic"
vmess.security = queryParam["security"] ?: "none"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently quic security should be put as vmess.requestHost.
This brings a question.. how does the new format carry vmess.securiity?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

现阶段,vmess的security取消,默认auto

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the new format finalised? If not I'd suggest we should add security.

Copy link
Contributor Author

@iseki0 iseki0 Jul 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until now, looks there is no plan for it. And I don't think we should add this feature. Because it can auto negotiation.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no matter which encryption has been choosed, client can always connect to server, so I don't think security option is necessary.

Copy link

@ghost ghost Jul 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello.
As far as I could tell, VMess could perform auto-negotiation and they suggest setting it to auto. So this is not required anymore.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it is not mandatory but it would be a convenient setting. "none" is a common choice with tls. Also user would expect to transfer basic settings with export-and-then-import. For instance..
#356
dalao @RPRX was surprised by it :)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That only happens when using the old standard. It's your parser's fault not to work correctly.
The new standard obsoletes this setting, so they are irrelevant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new version scheme has removed the paramter. I think it's viable to user, because of we don't use base64. So that user will understand what's happeded.

@2dust 2dust merged commit 881152e into 2dust:master Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants