-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphStage rewrite #22
Conversation
@gafiatulin thanks for contributing! I will give you feedback soon) |
@gafiatulin I'd like to cherry-pick library updates and cross building into master in order to release BTW, don't you mind to split the latest commit into another PR? I'd like to discuss the approach of using typeclasses like |
@gafiatulin I released |
@savulchik I rebased on current master. |
#23 is what I was looking for in the first place with that polymorphic source commit. I did it that way because it requires changes in interactions with underlying jeromq ( Not really sure about unmarshalling being done in source. Sources shouldn't be concerned with deserializing of incoming data into domain entities. Especially not with my initial approach. |
Fixes #21