Add a new "hub-experimental" hub image and enable unlisted choices for leap hub #2851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging this PR will trigger the following deployment actions. Support and Staging deployments
Production deployments
|
yuvipanda
reviewed
Jul 21, 2023
|
This looks great to me, @GeorgianaElena! Let's add docs and then we can merge. Thank you for exploring this approach, I think it would allow us to move faster safely. |
…ress to push it on quay
…for each of the profiles
GeorgianaElena
force-pushed
the
hub_test_image
branch
from
27fad18 to
97d8b7a
Compare
|
@yuvipanda, I've added some docs. I tried to add some, so that we can also close #2800. Do you think this is good enough? |
yuvipanda
reviewed
Jul 24, 2023
yuvipanda
changed the title
yuvipanda
reviewed
Jul 24, 2023
yuvipanda
reviewed
Jul 24, 2023
yuvipanda
reviewed
Jul 24, 2023
yuvipanda
reviewed
Jul 24, 2023
yuvipanda
reviewed
Jul 24, 2023
|
ok, I absolutely love the mermaid diagram as policy! THANK YOU @GeorgianaElena! I've left some minor style and similar comments, but this can be merged once you have addressed them / accepted the suggestions! THANK YOU! |
yuvipanda
approved these changes
Jul 24, 2023
Co-authored-by: Yuvi Panda <[email protected]>
Co-authored-by: Yuvi Panda <[email protected]>
Co-authored-by: Yuvi Panda <[email protected]>
Co-authored-by: Yuvi Panda <[email protected]>
|
Yay! Excited to see this go live :) |
|
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/5654078956 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
hub-experimentalimage for the hub, that we can use to test latest changes of pkgs for our hub image and deploy just to specific hubs before rolling a change to all the others (credits to @yuvipanda for proposing this solution to test latest kubespawner changes in https://2i2c.slack.com/archives/C05FP4UPTEE/p1689922103844759)the new image is available at https://quay.io/repository/2i2c/experimental-hub
it can be pushed using chartpress, just like the default hub image
hub-experimentalon leap hubs and enablesunlisted_choicefrom latestkubespawnermain, per Setup the profile list to allow a user specified image for leap.2i2c.cloud - for all server options #2146Needs:
hub-experimentalunlisted_choicesThis is how it looks like on leap staging (I also tried spawning a custom image and it worked 🎉 )
Closes #2146
Closes #2800