Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Enable unlisted image choice for researchdelight hub" #2891

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Revert "Enable unlisted image choice for researchdelight hub" #2891

merged 1 commit into from
Jul 31, 2023

Conversation

yuvipanda
Copy link
Member

@yuvipanda yuvipanda commented Jul 29, 2023 •
edited
Loading

Reverts #2880

Ref #2873

This did not pass CI, needs #2869
to be fixed

@yuvipanda yuvipanda requested a review from a team as a code owner July 29, 2023 15:59
@github-actions
Copy link

Merging this PR will trigger the following deployment actions.

Support and Staging deployments

Cloud Provider Cluster Name Upgrade Support? Reason for Support Redeploy Upgrade Staging? Reason for Staging Redeploy
aws 2i2c-aws-us No Yes Following prod hubs require redeploy: researchdelight

Production deployments

Cloud Provider Cluster Name Hub Name Reason for Redeploy
aws 2i2c-aws-us researchdelight Following helm chart values files were modified: researchdelight.values.yaml

yuvipanda added a commit to yuvipanda/pilot-hubs that referenced this pull request Jul 29, 2023
@yuvipanda
Add another item to self-merging list of exceptions
6ea7c07 
- Turn this into its own section, so it can be linked
- Add 'Clean revert of something that failed CI',
  so things like 2i2c-org#2891
  can be reverted
@yuvipanda yuvipanda mentioned this pull request Jul 29, 2023
Merged
@GeorgianaElena
Copy link
Member

This did not pass CI, needs #2869
to be fixed

@yuvipanda, yes! Also -> #2887 😞

@yuvipanda yuvipanda merged commit a34c509 into master Jul 31, 2023
@yuvipanda yuvipanda deleted the revert-2880-unlistd-choice-researchdel branch July 31, 2023 16:38
@github-actions
Copy link

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/5717281205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgianaElena GeorgianaElena GeorgianaElena approved these changes

Assignees

@yuvipanda yuvipanda

Labels
None yet
Projects
No open projects
Sprint Board
Status: Done 🎉
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuvipanda @GeorgianaElena