Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch built images in imagebuilder-demo! #3151

Merged
merged 15 commits into from
Sep 18, 2023

Conversation

yuvipanda
Copy link
Member

@yuvipanda yuvipanda commented Sep 15, 2023

  • Provides options for resource allocation that the user can select, showing that you can select what kinda resource you want while building image
  • Update image choices to be more reflective of what we would have in a real hub
  • Brings in a lot of changes from github.com/yuvipanda/prototype-kubespawner-dynamic-building-ui to support the
    following:
    • Built images are now actually launched! Yay!
    • The big piece of text proclaiming that this is a prototype that doesn't work is gone, as it does work
    • The build logs are collapsible
    • There's a poorly discsoverable message saying 'build is done, click to launch'.

Ref #3104

Here's a demo!

Screen.Recording.2023-09-16.at.12.16.23.AM.mov

(dropdown slightly tweaked with suggestions from @choldgraf)
image

So all the options in the dropdown work except for wiring up the built image to be actually launched.

- Provides options for resource allocation that the user can
  select, showing that you *can* select what kinda resource you
  want while building image
- Update image choices to be more reflective of what we would have
  in a real hub

Ref 2i2c-org#3104
@github-actions
Copy link

Merging this PR will trigger the following deployment actions.

Support and Staging deployments

Cloud Provider Cluster Name Upgrade Support? Reason for Support Redeploy Upgrade Staging? Reason for Staging Redeploy
gcp 2i2c No Yes Following prod hubs require redeploy: imagebuilding-demo

Production deployments

Cloud Provider Cluster Name Hub Name Reason for Redeploy
gcp 2i2c imagebuilding-demo Following helm chart values files were modified: imagebuilding-demo.values.yaml

@yuvipanda yuvipanda marked this pull request as ready for review September 15, 2023 21:45
@yuvipanda yuvipanda requested a review from a team as a code owner September 15, 2023 21:45
@yuvipanda yuvipanda marked this pull request as draft September 15, 2023 21:49
@yuvipanda yuvipanda changed the title Make resource selection more useful in imagebuilding-demo Streamline UI and allow unlisted_choice to work in imagebuilding-demo Sep 15, 2023
@yuvipanda yuvipanda marked this pull request as ready for review September 15, 2023 23:29
@yuvipanda yuvipanda changed the title Streamline UI and allow unlisted_choice to work in imagebuilding-demo Launch built images in imagebuilder-demo! Sep 16, 2023
Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yuhuuuuuu 🚀 🎉

@yuvipanda yuvipanda merged commit 046376a into 2i2c-org:master Sep 18, 2023
6 checks passed
@github-actions
Copy link

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/6226009942

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

2 participants