-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup UX of imagebuilding-demo #3155
Conversation
Merging this PR will trigger the following deployment actions. Support and Staging deployments
Production deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this improved UX a lot!
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/6237786578 |
This looks really nice 🎉 |
@arnim to cleanup unused images in the registry? or somewhere else? |
To cleanup unused images on a user level. |
And only in the list of images the user has imported. Not sure if this makes sense. Would probably not delete images in the registry. |
@arnim ah, so the list of images you see are coming from what the admins have set in config, not from the user level. So removing those is done by editing z2jh config. I do agree that separately, it would be useful to remember the images the user has built and allow them to rebuild / reuse. That functionality currently doesn't exist here though. |
In the old pBHub setup we also had the option to configure a "hallo world" image/repo, but did later not distinguish between admin configured images and user imported images. Not sure if something in this direction makes sense here as well. |
CSS grid instead. Makes things much easier.
shipped with kubespawner - use https://react-select.com/ so we can actually
have a useful description with each option the user can select. This is
specified by admin when setting up profileList, and is ignored by the default
profileList renderer. Very useful in setting context!
before.
will be re-introduced in the near future. Same for ability to hide the build log,
although that is less of an issue now that the logs are smaller.
allocations are oredered.
as well except for typing.
Here is a demo:
Screen.Recording.2023-09-19.at.12.37.43.AM.mov
Ref #3104