Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup UX of imagebuilding-demo #3155

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Conversation

yuvipanda
Copy link
Member

@yuvipanda yuvipanda commented Sep 19, 2023

  • Get rid of the ancient bootstrap3 code for doing layouts, use moden native
    CSS grid instead. Makes things much easier.
  • First real feature for profiles that isn't supported in the simple jinja2 template
    shipped with kubespawner - use https://react-select.com/ so we can actually
    have a useful description with each option the user can select. This is
    specified by admin when setting up profileList, and is ignored by the default
    profileList renderer. Very useful in setting context!
  • UX is generally cleaner and melds in together nicer, vs being more disjointed
    before.
  • The ability to explicitly specify the GitHub repos' ref has been removed, and
    will be re-introduced in the near future. Same for ability to hide the build log,
    although that is less of an issue now that the logs are smaller.
  • Brings in Don't sort keys by default in tojson when rendering profile forms jupyterhub/kubespawner#787, so resource
    allocations are oredered.
  • Brings in these changes for the UI: 2i2c-org/jupyterhub-fancy-profiles@19aa368...e7a3b86
  • pre-commit is now setup in the UI repo, and mostly clean. eslint is mostly clean
    as well except for typing.

Here is a demo:

Screen.Recording.2023-09-19.at.12.37.43.AM.mov

Ref #3104

@yuvipanda yuvipanda requested a review from a team as a code owner September 19, 2023 07:34
@github-actions
Copy link

Merging this PR will trigger the following deployment actions.

Support and Staging deployments

Cloud Provider Cluster Name Upgrade Support? Reason for Support Redeploy Upgrade Staging? Reason for Staging Redeploy
gcp 2i2c No Yes Following prod hubs require redeploy: imagebuilding-demo

Production deployments

Cloud Provider Cluster Name Hub Name Reason for Redeploy
gcp 2i2c imagebuilding-demo Following helm chart values files were modified: imagebuilding-demo.values.yaml

Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this improved UX a lot!

@yuvipanda yuvipanda merged commit bd76368 into 2i2c-org:master Sep 19, 2023
7 checks passed
@github-actions
Copy link

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/6237786578

@arnim
Copy link

arnim commented Sep 20, 2023

This looks really nice 🎉
Do we need a delete option for images as well?

@yuvipanda
Copy link
Member Author

@arnim to cleanup unused images in the registry? or somewhere else?

@arnim
Copy link

arnim commented Sep 20, 2023

To cleanup unused images on a user level.

@arnim
Copy link

arnim commented Sep 20, 2023

And only in the list of images the user has imported. Not sure if this makes sense.

Would probably not delete images in the registry.

@yuvipanda
Copy link
Member Author

@arnim ah, so the list of images you see are coming from what the admins have set in config, not from the user level. So removing those is done by editing z2jh config.

I do agree that separately, it would be useful to remember the images the user has built and allow them to rebuild / reuse. That functionality currently doesn't exist here though.

@arnim
Copy link

arnim commented Sep 20, 2023

In the old pBHub setup we also had the option to configure a "hallo world" image/repo, but did later not distinguish between admin configured images and user imported images.

Not sure if something in this direction makes sense here as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

3 participants