Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename UI project to jupyterhub-fancy-profiles #3164

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Rename UI project to jupyterhub-fancy-profiles #3164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dae5e90
Rename kubespawner-dynamicbuilder-ui to jupyterhub-fancy-profiles
yuvipanda Sep 20, 2023
94db052
Bump built image tag
yuvipanda Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions config/clusters/2i2c/imagebuilding-demo.values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ jupyterhub:
url: http://imagebuilding-demo-binderhub-service:8090
image:
name: quay.io/2i2c/dynamic-image-building-experiment
tag: "0.0.1-0.dev.git.7060.h0593e80c"
tag: "0.0.1-0.dev.git.7067.hdae5e902"
config:
JupyterHub:
authenticator_class: github
Expand All @@ -138,12 +138,9 @@ jupyterhub:
- read:org

extraConfig:
enable-prototype-UI: |
from kubespawner_dynamic_building_ui import TEMPLATE_PATHS, STATIC_HANDLER_TUPLE
c.KubeSpawner.additional_profile_form_template_paths = TEMPLATE_PATHS

# Add extra handler to serve JS & CSS assets
c.JupyterHub.extra_handlers.append(STATIC_HANDLER_TUPLE)
enable-fancy-profiles: |
from jupyterhub_fancy_profiles import setup_ui
setup_ui(c)

binderhub-service:
nodeSelector:
Expand Down
6 changes: 3 additions & 3 deletions helm-charts/images/hub/dynamic-image-building-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
git+https://github.com/yuvipanda/jupyterhub-configurator@ed7e3a0df1e3d625d10903ef7d7fd9c2fbb548db
# Brings on using `unlisted_choice` in profile options per https://github.com/2i2c-org/infrastructure/issues/2146
# Brings in https://github.com/jupyterhub/kubespawner/pull/787
git+https://github.com/yuvipanda/kubespawner@46d561d2687b3d6d5ea0dd0e25db42945c886b91
# Brings in https://github.com/yuvipanda/prototype-kubespawner-dynamic-building-ui
git+https://github.com/yuvipanda/prototype-kubespawner-dynamic-building-ui.git@e7a3b86879ada4065d70343b51453e144ab6cad3
git+https://github.com/jupyterhub/kubespawner@d60146f5fe9cd31e09acf13c377d9334ecf59c9b
# Brings in https://github.com/yuvipanda/jupyterhub-fancy-profiles
git+https://github.com/yuvipanda/jupyterhub-fancy-profiles@b624031b661f71a278a37bb1fae0b8d6f316d6b3