Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore replica busy condition in healthcheck #6630

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

progier389
Copy link
Contributor

Replica Busy condition is expected when there is more than 2 suppliers so healthcheck should not report any error for such condition.

Issue: #6626

Reviewed by: ?

Copy link
Contributor

@tbordaz tbordaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I think you also need to update existing calls to run_healthcheck_and_flush_log to set isnot=True|False.

@progier389
Copy link
Contributor Author

I think you also need to update existing calls to run_healthcheck_and_flush_log to set isnot=True|False.

isnot is an optional parameter with False as default value, so there is no need to change the existing calls (they will just use False for isnot ...

@progier389
Copy link
Contributor Author

test_healthcheck_replication_out_of_sync_broken is failing:
ERROR:dirsrvtests.tests.suites.healthcheck.health_repl_test:DSREPLLE0001 is not in healthcheck output:
Both in bdb and lmdb
Maybe there is a side effect ?

@progier389
Copy link
Contributor Author

Apparently that is a test case issue: test_healthcheck_replication_out_of_sync_broken has a race condition allowing to run healthcheck before replication is out of sync (because agmt fro M1 to M2,M3 are not broken.
Changing the test to do updates on all instances, and restore broken replica once the test is finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants