Revert "Issue #6562 - Prevent undefined behaviour in in filter_stuff_func (#6563)" #6634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tuff_func (389ds#6563)" This reverts commit c27fe45. Reverting c27fe45 that is causing an heap corruption: buffer overflow
|
Reverting the commit, but this is strange as the change seems trivial. |
|
Indeed the way get_filter_internal and get_filter_list handles fstr/ftmp seems a bit fishy |
|
I do not understand why filter_escape_filter_value_extended is trying to use a ftmp value (it should only access to the filter data but not to the filter string ....) |
|
I still propose to revert the original fix (to avoid having failing tests) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c27fe45.
Reverting c27fe45 that is causing
an heap corruption: buffer overflow
Issue: #6562
Reviewed by: @tbordaz , @droideck (Thanks!)