feat(time-preferences): add time grid for users to select study time … #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Preview for this PR is available at: https://studybuddy-8086e--pr-6-3aw8p2so.web.app |
|
Could you use F12 and select here to see what it looks like on mobile?
|
1. time only contain hour. 2. Use abbrev for dates in week. 3. Add select for "No earlier than" and "No later than". 4. Add "Include Weekends" toggle.
github-actions
bot
added
size/L
|
🚀 Preview for this PR is available at: https://studybuddy-8086e--pr-6-3aw8p2so.web.app |
|
|
|
Okay let me do that and fix that.
…On Tue, Oct 15, 2024 at 7:32 PM Elara Liu ***@***.***> wrote:
Could you use F12 and select here to see what it looks like on mobile?
QQ_1729038725097.png (view on web)
<https://github.com/user-attachments/assets/d9995bc0-58b4-4561-9691-2acbb9c8e917>
—
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BL3LZJ2C3XILCR5ALF6OL7LZ3WX3VAVCNFSM6AAAAABQAISCOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJVGM4TMNBWGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Btw this was just the front end, finishing up the back end code right now
since firebase has started working
…On Tue, Oct 15, 2024 at 9:05 PM Elara Liu ***@***.***> wrote:
QQ_1729044247536.png (view on web)
<https://github.com/user-attachments/assets/ca9f142c-b541-4b1d-9f2e-f3d1d1d49ebc>
—
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BL3LZJ43C56ZVO2WBN2V7LLZ3XCVHAVCNFSM6AAAAABQAISCOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJVGU3TKOBZGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
ZL-Asica
approved these changes
Oct 16, 2024
|
@WelldoneM You can open a new PR for that after this is approved. That will make things easier. |
WeiViv
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…preferences
Please include a summary of the changes and the related issue.
Type of change
Checklist