Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mvp polygon offset #1000

Closed
wants to merge 2 commits into from
Closed

mvp polygon offset #1000

wants to merge 2 commits into from

Conversation

kfarr
Copy link
Collaborator

@kfarr kfarr commented Jan 1, 2025 •
edited
Loading

allows us to use logdepthbuffer = false, therefore splats in production!

other things to consider later:

  • intersection striping also needs polygon offset
  • vehicles or building models with excessive z fighting need to be fixed separately
  • should this be changed to a component instead of manually applied? therefore this would be able to persist even if the object is detached from the generation component?

@kfarr kfarr changed the base branch from main to epic-street-editing January 2, 2025 00:59
@kfarr kfarr marked this pull request as ready for review January 2, 2025 01:00
@kfarr kfarr changed the base branch from epic-street-editing to main January 2, 2025 01:04
@kfarr kfarr changed the base branch from main to epic-street-editing January 2, 2025 01:04
@kfarr
Copy link
Collaborator Author

kfarr commented Jan 2, 2025

see #1004

@kfarr kfarr closed this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kfarr