Skip to content

Commit

Permalink
Merge pull request #962 from 3YOURMIND/eslint-config-prune-untyped-rules
Browse files Browse the repository at this point in the history
version([email protected]): remove rules requiring types from `untyped`
  • Loading branch information
Isokaeder authored Jul 9, 2024
2 parents 2dd3286 + 574c9c6 commit b9dcee4
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion packages/eslint-config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,5 +62,5 @@
},
"type": "module",
"types": "./dist/mjs/index.d.ts",
"version": "0.0.8"
"version": "0.0.9"
}
20 changes: 10 additions & 10 deletions packages/eslint-config/source/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -117,16 +117,6 @@ const baseConfig = tseslint.config({
...ignoredRules,

// Typescript Eslint
'@typescript-eslint/ban-ts-comment': [
'error',
{
'ts-expect-error': 'allow-with-description',
minimumDescriptionLength: 24,
},
],
'@typescript-eslint/explicit-function-return-type': 'off',
'@typescript-eslint/explicit-module-boundary-types': 'error',
'@typescript-eslint/no-empty-interface': 'error',
'@typescript-eslint/no-namespace': 'off', // We want to be able to use modules for namespacing
'@typescript-eslint/no-unsafe-enum-comparison': 'off', // This rule forbids comparing enums with their literal member values, which is useful in many cases
'@typescript-eslint/no-unused-vars': [
Expand Down Expand Up @@ -210,7 +200,16 @@ const defaultNamingConventionConfig = {
}

const rulesRequiringTypes = {
'@typescript-eslint/ban-ts-comment': [
'error',
{
'ts-expect-error': 'allow-with-description',
minimumDescriptionLength: 24,
},
],
'@typescript-eslint/consistent-type-imports': 'warn',
'@typescript-eslint/explicit-function-return-type': 'off',
'@typescript-eslint/explicit-module-boundary-types': 'error',
'@typescript-eslint/naming-convention': [
'error',
{
Expand Down Expand Up @@ -262,6 +261,7 @@ const rulesRequiringTypes = {
*/
{ ignoreUnions: true },
],
'@typescript-eslint/no-empty-interface': 'error',
'@typescript-eslint/no-unnecessary-condition': 'error',
'@typescript-eslint/no-unnecessary-type-arguments': 'warn',
'@typescript-eslint/no-unnecessary-type-assertion': 'error',
Expand Down

0 comments on commit b9dcee4

Please sign in to comment.