-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow valid set() calls without a callback to proceed. These were fa… #249
Open
bdunavant
wants to merge
1
commit into
3rd-Eden:master
Choose a base branch
from
bdunavant:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
validateArg is supposed to confirm that an argument is a particular type. It seems like a bad place to turn all function arguments into optionals system wide. There must be a better place for this, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ grep -r validateArg *
lib/memcached.js: if (query.validate && !Utils.validateArg(query, this)) {
lib/utils.js:exports.validateArg = function validateArg (args, config) {
"system wide" seems to be this one call inside of "command", so in all cases that I'm aware of, it is the callback. So in all of those cases (globally?), "undefined" is actually a valid value for that argument. Perhaps renaming "validateArg" to "validateCommandArg" would make that clearer if you still feel strongly about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess my point is that if it's optional, you may want to check for optionality before calling this function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell, passed functions are always callbacks, so they should be globally optional. I have been unable to find any place where they are not, so that seems to me that would be writing code support for a case that doesn't exist. I'm not intimately familiar with the module though, so please correct me if you know of one.
If there is one, IMO, simply checking for optionality before the call would require that I then pass a "fake" function to validateArg in order to get it to pass which seems very hacky. If this is absolutely necessary I would add another item to the config called "OptionalFunction" and copy/paste the "Function" code except also allowing undefined, and then globally find/replace Function with OptionalFunction in every command config definition.
But again, unless a case is identified, this seems like code bloat for a situation that doesn't exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bdunavant I understand your case. I'm also not 100% intimately familiar with the entire codebase however.
@3rd-Eden, any input?