Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tekton resources #2

Merged
merged 2 commits into from
Sep 7, 2023
Merged

feat: add tekton resources #2

merged 2 commits into from
Sep 7, 2023

Conversation

raelga
Copy link
Contributor

@raelga raelga commented Sep 6, 2023

@3scale-robot 3scale-robot added the needs-kind Indicates a PR or issue lacks a `kind/foo` label and requires one. label Sep 6, 2023
@3scale-robot
Copy link
Contributor

@raelga: There are no kind on this issue.
Please add an appropriate kind by using one of the following commands:

  • /kind bug
  • /kind cleanup
  • /kind documentation
  • /kind feature
  • /kind <kind-name>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@3scale-robot 3scale-robot added needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/L Requires few days to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Sep 6, 2023
@raelga
Copy link
Contributor Author

raelga commented Sep 6, 2023

/kind feature
/kind bug
/priority important-soon
/assign

@3scale-robot
Copy link
Contributor

@raelga: The label(s) kind/feature, kind/bug, priority/important-soon cannot be applied, because the repository doesn't have them.

In response to this:

/kind feature
/kind bug
/priority important-soon
/assign

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

roivaz
roivaz approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@roivaz roivaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks god. This should be 0.3.0 as it adds new functionality (new managed resources).

@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2023
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f513a6b3b22eaf54e32857d28a302034a6c0a3c8

@slopezz
Copy link
Member

slopezz commented Sep 6, 2023

/lgtm

@raelga
Copy link
Contributor Author

raelga commented Sep 7, 2023

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raelga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2023
@3scale-robot 3scale-robot merged commit 9c2d806 into main Sep 7, 2023
1 check passed
@3scale-robot 3scale-robot deleted the feat/add-tekton-resources branch September 7, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roivaz roivaz roivaz approved these changes

@slopezz slopezz Awaiting requested review from slopezz

Assignees

@raelga raelga

@roivaz roivaz

@slopezz slopezz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-kind Indicates a PR or issue lacks a `kind/foo` label and requires one. needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. size/L Requires few days to complete the PR or the issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raelga @3scale-robot @slopezz @roivaz