Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/generic-secret #221

Merged
merged 13 commits into from
Mar 26, 2024
Merged

feat/generic-secret #221

merged 13 commits into from
Mar 26, 2024

Conversation

roivaz
Copy link
Member

@roivaz roivaz commented Mar 22, 2024

  • Adds the possibility of generating envoy generic secrets from k8s type=Opaque Secrets.
  • Adds an example using the oauth2 envoy filter, which uses generic secrets
  • Updates envoy protos to envoyproxy/go-control-plane@7f2a24d
  • Updates the proto generator to accept go pseudoversions

Related to #218

/kind feature
/piority important-longterm
/assign

@3scale-robot 3scale-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 22, 2024
@3scale-robot 3scale-robot added needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/L Requires few days to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Mar 22, 2024
@roivaz roivaz mentioned this pull request Mar 22, 2024
Closed
@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8d42112d255f67b9a1b491540f5fdf0bb22a121c

@roivaz
Copy link
Member Author

roivaz commented Mar 26, 2024

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2024
@3scale-robot 3scale-robot merged commit d57c3f2 into main Mar 26, 2024
3 of 4 checks passed
@3scale-robot 3scale-robot deleted the feat/generic-secret branch March 26, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raelga raelga raelga approved these changes

@slopezz slopezz Awaiting requested review from slopezz

Assignees

@raelga raelga

@roivaz roivaz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. size/L Requires few days to complete the PR or the issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roivaz @3scale-robot @raelga