Feature/partial reloading #49
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,112 @@ | ||
| // | ||
| // TableViewController+Reload.swift | ||
| // ThunderTable | ||
| // | ||
| // Created by Simon Mitchell on 17/07/2018. | ||
| // Copyright © 2018 3SidedCube. All rights reserved. | ||
| // | ||
|
|
||
| import UIKit | ||
|
|
||
| extension TableViewController { | ||
|
|
||
| /// Finds the index path for a particular row. | ||
| /// | ||
| /// - Note: The row in question must conform to Equatable for this to succeed. | ||
| /// | ||
| /// - Parameter row: The row to find the index path for. | ||
| /// - Returns: The index path the row is positioned at if it is in `data`. | ||
| public func indexPathFor<T: Row & Equatable>(row: T) -> IndexPath? { | ||
|
|
||
| for (index, section) in data.enumerated() { | ||
|
|
||
| guard let matchingRowIndex = section.rows.firstIndex(where: { | ||
| guard let matchableRow = $0 as? T else { return false } | ||
| return matchableRow == row | ||
| }) else { | ||
| continue | ||
| } | ||
|
|
||
| return IndexPath(row: matchingRowIndex, section: index) | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| /// Replaces a row in `data` with another row, whilst optionally reloading other index paths. | ||
| /// | ||
| /// - Note: This relies on the containing section of the row being of class `TableSection` as apposed to any object conforming to `Section` | ||
| /// | ||
| /// - Parameters: | ||
| /// - row: The row that should be replaced. | ||
| /// - otherRow: The row that is replacing the original row. | ||
| /// - additionalReloadIndexPaths: Additional index paths that should be reloaded at the same time. | ||
| /// - animation: The animation to use when reloading the rows | ||
| public func replace<T: Row & Equatable>(row: T, with otherRow: Row, reloading additionalReloadIndexPaths: [IndexPath] = [], animation: UITableView.RowAnimation = .none) { | ||
|
There was a problem hiding this comment. Would be nice to reuse the array option below if we can, save code duplication - happy to leave ofc |
||
|
|
||
| guard let indexPath = indexPathFor(row: row) else { return } | ||
| guard let tableSection = data[indexPath.section] as? TableSection else { return } | ||
|
There was a problem hiding this comment. Is There was a problem hiding this comment.
|
||
|
|
||
| var rows = tableSection.rows | ||
| rows[indexPath.row] = otherRow | ||
| tableSection.rows = rows | ||
|
|
||
| withoutRedrawing { | ||
| data[indexPath.section] = tableSection | ||
| } | ||
|
|
||
| var indexPaths = [indexPath] | ||
| indexPaths.append(contentsOf: additionalReloadIndexPaths) | ||
|
There was a problem hiding this comment. Happy to leave, but user's could wrap |
||
| tableView.reloadRows(at: indexPaths, with: animation) | ||
| } | ||
|
|
||
| /// Replaces multiple rows with replacement rows. | ||
| /// | ||
| /// - Note: This relies on the containing section of each row being of class `TableSection` as apposed to any object conforming to `Section`. | ||
| /// | ||
| /// - Parameters: | ||
| /// - rows: The rows to replace. | ||
| /// - otherRows: The rows they should be replaced by. | ||
| /// - animation: The row animation to use when replacing | ||
| public func replace<T: Row & Equatable>(rows: [T], with otherRows: [Row], animation: UITableView.RowAnimation) { | ||
|
|
||
| guard rows.count == otherRows.count else { return } | ||
|
|
||
| let replacement: [(Int, IndexPath)] = rows.enumerated().compactMap({ | ||
| guard let indexPath = indexPathFor(row: $0.element) else { return nil } | ||
| return ($0.offset, indexPath) | ||
| }) | ||
|
|
||
| replacement.forEach { (index, indexPath) in | ||
|
|
||
| guard let tableSection = data[indexPath.section] as? TableSection else { return } | ||
|
There was a problem hiding this comment. Again do we need |
||
|
|
||
| var rows = tableSection.rows | ||
| rows[indexPath.row] = otherRows[index] | ||
| tableSection.rows = rows | ||
|
|
||
| withoutRedrawing { | ||
| data[indexPath.section] = tableSection | ||
| } | ||
| } | ||
|
|
||
| tableView.reloadRows(at: replacement.map({ $0.1 }), with: animation) | ||
| } | ||
|
|
||
| /// Reloads the cell at the indexPath for a given row. | ||
| /// | ||
| /// - Parameters: | ||
| /// - row: The row to reload the cell for. | ||
| /// - animation: The animation to use when redrawing | ||
| public func redraw<T: Row & Equatable>(row: T, with animation: UITableView.RowAnimation = .none) { | ||
|
|
||
| guard let indexPath = indexPathFor(row: row) else { return } | ||
| tableView.reloadRows(at: [indexPath], with: animation) | ||
|
There was a problem hiding this comment. If we are using animation shouldn't we wrap in a |
||
| } | ||
|
|
||
| /// The last available indexPath in the tableView | ||
| public var lastIndexPath: IndexPath? { | ||
| guard let lastSection = data.last(where: { !$0.rows.isEmpty }) else { return nil } | ||
| return IndexPath(row: lastSection.rows.count - 1, section: data.count - 1) | ||
|
There was a problem hiding this comment. If there's There was a problem hiding this comment. Ooooh yikes yep this needs more consideration! |
||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could do fancy setters on
subscriptshere! But let's leave that for now 😄. Bit OTT