Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush changes from 1.0-FTY-master into 1.0-FTY "stable" #24

Merged
merged 29 commits into from
Jun 17, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
92bffa5
Problem: server can segfault due to incomplete connections
Mar 30, 2017
888f711
Problem: regression test is broken
Apr 2, 2017
a483dc1
Update mlm_server_engine.inc with new client refcounting support
michal42 Jan 23, 2018
f1f6896
Properly handle pending stream traffic after client disconnect
michal42 Jan 23, 2018
2de38c4
Add regression test for race condition with pending stream traffic
michal42 Jan 23, 2018
28ab1a2
Merge pull request #13 from michal42/upstream-fixes-master
jana-rapava Jan 24, 2018
b85f6f9
Merge pull request #14 from michal42/client-refcount-42ity
EldoreiJK Feb 5, 2018
8468243
Makemodule.am : fix selftest reference
jimklimov Apr 6, 2018
f8768e2
Problem : invalid command log misses the command itself
geraldguillaume Jun 22, 2018
b013c42
Merge pull request #16 from geraldguillaume/1.0-FTY-master
aquette Jun 22, 2018
c918814
Zproject regen before 1.5.0 branching
jana-rapava Nov 13, 2018
7916d8b
backport f96bc80cec81c29 from upstream : client unique identifier is …
geraldguillaume Jan 4, 2018
232d60d
Merge pull request #19 from geraldguillaume/1.0-FTY-master
barraudl Nov 28, 2018
dc3b479
Merge pull request #18 from jana-rapava/1.0-FTY-master
geraldguillaume Nov 28, 2018
411e840
Zproject regen before 1.5.0 branching
jana-rapava Nov 13, 2018
003fb65
Jenkinsfile : update references for CI buildenv from 1.3 to 1.5.0
jimklimov Dec 4, 2018
32103c7
Update Jenkinsfile with recent feature baseline from zproject
jimklimov Dec 4, 2018
aa4ade1
Merge pull request #20 from jimklimov/markup-20181114
jimklimov Dec 4, 2018
895c23f
Jenkinsfile : copy-paste typo fix (define GIT_URL *before* using it)
jimklimov Dec 5, 2018
395f3c8
configure.ac : add support for --enable-address-sanitizer=yes/no
jimklimov Sep 3, 2018
f32bd2d
Merge branch '1.0-FTY' into 1.0-FTY-master
jimklimov Dec 5, 2018
cb95a5c
[issues/217] mlm_client_set_consumer broke the stream when pattern is *
geraldguillaume Mar 5, 2019
3f34e6a
[issues/217] fix comment syntax
geraldguillaume Mar 5, 2019
537b379
We should reject invalid regexes
geraldguillaume Mar 8, 2019
70c81d1
use correct pattern variable
geraldguillaume Mar 8, 2019
90b2995
Merge pull request #22 from geraldguillaume/1.0-FTY-master
boricj Mar 8, 2019
f285b77
Problem: "snprintf_chk output truncated before the last format charac…
jimklimov Apr 29, 2019
1fbb2b5
Merge pull request #23 from jimklimov/fix-warnings
jimklimov Apr 29, 2019
f8bf8e0
Problem: typo in comment of mlm_client_engine.inc mlm_client_set_cons…
jimklimov May 27, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/mlm_client_engine.inc
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ s_client_new (zsock_t *cmdpipe, zsock_t *msgpipe)
self->msgpipe = msgpipe;
self->state = start_state;
self->event = NULL_event;
snprintf (self->log_prefix, sizeof (self->log_prefix) - 1,
snprintf (self->log_prefix, sizeof (self->log_prefix),
"%6d:%-33s", randof (1000000), "mlm_client");
self->dealer = zsock_new (ZMQ_DEALER);
if (self->dealer)
Expand Down Expand Up @@ -1723,7 +1723,11 @@ int
mlm_client_set_consumer (mlm_client_t *self, const char *stream, const char *pattern)
{
assert (self);

// https://github.com/zeromq/malamute/issues/217
// problem : if pattern "*" is used, the related stream will be broken and
// mlm broker will start overconsuming 100% CPU forever
if (streq(pattern,"*"))
return -1;
zsock_send (self->actor, "sss", "SET CONSUMER", stream, pattern);
if (s_accept_reply (self, "SUCCESS", "FAILURE", NULL))
return -1; // Interrupted or timed-out
Expand Down
2 changes: 1 addition & 1 deletion src/mlm_server_engine.inc
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ engine_set_log_prefix (client_t *client, const char *string)
{
if (engine_client_is_valid (client)) {
s_client_t *self = (s_client_t *) client;
snprintf (self->log_prefix, sizeof (self->log_prefix) - 1,
snprintf (self->log_prefix, sizeof (self->log_prefix),
"%6d:%-33s", self->unique_id, string);
}
}
Expand Down