Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ”¨ [Refactor] Multi module 적용 #587

Merged
merged 33 commits into from
Feb 23, 2024
Merged

πŸ”¨ [Refactor] Multi module 적용 #587

merged 33 commits into from
Feb 23, 2024

Conversation

Kimhan-nah
Copy link
Member

@Kimhan-nah Kimhan-nah commented Feb 20, 2024

πŸ“Œ κ°œμš”

  • λ©€ν‹° λͺ¨λ“ˆ 적용

πŸ’» μž‘μ—…μ‚¬ν•­

  • λ©€ν‹° λͺ¨λ“ˆ ꡬ쑰
    • gg-pingpong-data
      • Entity, Enum Type
    • gg-pingpong-admin-repo
    • gg-pingpong-repo
    • gg-pingpong-api
    • gg-pingpong-utils
  • repo λͺ¨λ“ˆ ν•˜μœ„μ˜ out λ””λ ‰ν† λ¦¬λŠ” repositoryμ—μ„œ λ¦¬ν„΄ν•˜λŠ” interfaceμž…λ‹ˆλ‹€.

domain별 Entity 정리 (type, redis μ œμ™Έ)

game
- Game
- PChange
- Team
- TeamUser
manage
- Announcement
- Feedback
- Penalty
- SlotManagement
match
- RedisMatchTime
- RedisMatchUser
noti
- Noti
rank
- Rank
- Tier
store
- CoinHistory
- CoinPolicy
- Item
- Megaphone
- Receipt
tournament
- Tournament
- TournamentGame
- TournamentUser
user
- User
- UserImage


πŸ’‘Issue 번호

@Kimhan-nah Kimhan-nah changed the title Multi module πŸ”¨ [Refactor] Multi module 적용 Feb 21, 2024
@Kimhan-nah Kimhan-nah marked this pull request as ready for review February 21, 2024 11:06
@AYoungSn AYoungSn self-requested a review February 22, 2024 06:16
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 77.61194% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 75.39%. Comparing base (3193717) to head (b5a13bb).
Report is 31 commits behind head on dev.

Files Patch % Lines
...gpong/api/admin/user/service/UserAdminService.java 14.28% 6 Missing ⚠️
...ngpong/api/user/rank/redis/RedisUploadService.java 0.00% 5 Missing ⚠️
...n/java/gg/pingpong/api/PingpongApiApplication.java 33.33% 2 Missing ⚠️
...i/controller/request/NotiFindByUserRequestDto.java 0.00% 1 Missing ⚠️
...controller/response/NotiFindByUserResponseDto.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##                dev     #587       +/-   ##
=============================================
+ Coverage     10.25%   75.39%   +65.13%     
- Complexity       78      926      +848     
=============================================
  Files           255      228       -27     
  Lines          3812     4048      +236     
  Branches        357      386       +29     
=============================================
+ Hits            391     3052     +2661     
+ Misses         3410      823     -2587     
- Partials         11      173      +162     
Flag Coverage Ξ”
integrationTest 70.47% <76.11%> (?)
unitTest 31.89% <40.29%> (+21.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

AYoungSn
AYoungSn previously approved these changes Feb 22, 2024
middlefitting
middlefitting previously approved these changes Feb 23, 2024
Copy link
Member

@middlefitting middlefitting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λΉŒλ“œλž‘ ci νŒŒμΌλ„ λ‹€ 맞게 μˆ˜μ •ν•΄μ£Όμ…¨λ„€μš” κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€.

Copy link
Contributor

@AYoungSn AYoungSn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ‹€λ“€ κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€~!

@wken5577 wken5577 merged commit 900aa36 into dev Feb 23, 2024
2 checks passed
@AYoungSn AYoungSn deleted the multi-module branch February 23, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

πŸ”¨ [Refactoring] λ©€ν‹° λͺ¨λ“ˆ 적용
5 participants