[cob_sick_s300] Propose to use portable serial library for cross-platform #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fmessmer Happy new year! Just wanted to ping and see any feedback on this. My goal is to make |
|
@seanyen |
|
@fmessmer Hi! Just checking did you get any chances trying this out with a scanner? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is attempting to enable
cob_sick_s300to be built and running onWindowsbuild.WinSockheaders and libraries as needed.boost::this_thread::sleep_for(boost::chrono::seconds(1))to do portable sleep.serial(and GitHub link) library for better portability.I understand the changes on
serialside are much, but would like to start a conversation how we can make this package more accessible to other platforms.