Add support for oneof #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
match expression on complete words only
Add support for oneof as named union
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for your work on proto2cpp. I added support for oneof which I think is extremely useful in protobuf. Before, it was keeping them as oneof which was handled by doxygen poorly : it was removing the first member and reporting it as the initial value. As those are union in the C implementation, I thought it would be okay to have them as union in the documentation.
And I happened to have a member called "messages" which was replaced with "s" and the line converted to a "struct" declaration. So I fixed it by matching on words only for "message" and "enum" (and now "oneof" too).
Cheers,
Yann