refactor: refactor (#26)

4m-mazi · Jan 23, 2024 · fc61df0 · fc61df0
1 parent cdef7f5
commit fc61df0
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 45 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/src/internal/utils.ts b/src/internal/utils.ts
@@ -1,4 +1,7 @@
-export const convertRef = ((str, { refType }) => {
+export const convertRef = (
+  str: string | undefined | null,
+  { refType }: { refType: 'branch' | 'tag' | 'pull' }
+): string | null => {
   if (str === null || str === undefined) return null
   if (str.startsWith('refs/')) return str
   switch (refType) {
@@ -8,10 +11,5 @@ export const convertRef = ((str, { refType }) => {
       return `refs/tags/${str}`
     case 'pull':
       return `refs/pull/${str}/merge`
-    default:
-      return null
   }
-}) satisfies (
-  str: string | undefined | null,
-  { refType }: { refType: 'branch' | 'tag' | 'pull' }
-) => string | null
+}
diff --git a/src/ref.ts b/src/ref.ts
@@ -7,7 +7,13 @@ import {
 } from './schema'
 import { convertRef } from './internal/utils'
 
-export const getRef = (({ eventName, payload }) => {
+export const getRef = ({
+  eventName,
+  payload
+}: {
+  eventName: string
+  payload: WebhookPayload
+}): string | null => {
   switch (eventName) {
     case 'check_run':
       return convertRef(
@@ -23,9 +29,6 @@ export const getRef = (({ eventName, payload }) => {
         { refType: 'branch' }
       )
     case 'create':
-      return convertRef(v.parse(NullableStringSchema, payload.ref), {
-        refType: payload.ref_type
-      })
     case 'delete':
       return convertRef(v.parse(NullableStringSchema, payload.ref), {
         refType: payload.ref_type
@@ -45,17 +48,8 @@ export const getRef = (({ eventName, payload }) => {
         }
       )
     case 'pull_request':
-      return convertRef(payload.pull_request?.number.toString(), {
-        refType: 'pull'
-      })
     case 'pull_request_review':
-      return convertRef(payload.pull_request?.number.toString(), {
-        refType: 'pull'
-      })
     case 'pull_request_review_comment':
-      return convertRef(payload.pull_request?.number.toString(), {
-        refType: 'pull'
-      })
     case 'pull_request_target':
       return convertRef(payload.pull_request?.number.toString(), {
         refType: 'pull'
@@ -88,10 +82,4 @@ export const getRef = (({ eventName, payload }) => {
     default:
       throw new Error(`${eventName} event is not supported.`)
   }
-}) satisfies ({
-  eventName,
-  payload
-}: {
-  eventName: string
-  payload: WebhookPayload
-}) => string | null
+}