-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a preset to add labels #181
Conversation
Default and GitHub Actions labels will be added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- .github/renovate.json: Language not supported
WalkthroughThe pull request modifies the Renovate configuration file Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/renovate.json (2)
3-3
: Ensure documentation of preset behaviorWhile using presets can help standardize configurations across repositories, it's important to document the expected behavior of these presets for maintainers.
Consider adding a comment in the JSON file to explain what labels are being added:
{ "$schema": "https://docs.renovatebot.com/renovate-schema.json", + // Uses default presets from 5ouma/utils and adds standardized labels for dependency updates "extends": ["github>5ouma/utils", "github>5ouma/utils:labels"] }
3-3
: Verify impact of removing direct label configurationsThe change moves label management to a preset. This is a good practice for maintaining consistent labels across repositories.
Consider these benefits of using presets:
- Centralized label management
- Consistent labeling across repositories
- Easier updates to label configurations
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/renovate.json
(1 hunks)
🔇 Additional comments (1)
.github/renovate.json (1)
3-3
: Verify the existence and content of the referenced presets
The configuration now uses presets from the 5ouma/utils
repository. Let's verify their existence and content.
✅ Verification successful
✅ The referenced presets exist and are properly configured
The repository 5ouma/utils
contains both the base preset (default.json
) and labels preset (labels.json
) in its root directory. The labels preset properly configures:
- Default label "🔄️ Dependencies" for all updates
- Special label "🛠 Meta" for GitHub Actions updates
This change aligns with the PR objectives to add default and GitHub Actions labels while maintaining a cleaner configuration through preset inheritance.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the existence and content of the Renovate presets
# Check if the repository exists and is accessible
gh repo view 5ouma/utils
# Search for Renovate preset files
rg -g '*.json' -l 'preset|labels' || echo "No preset files found"
# Look for any Renovate configuration files
fd -e json renovate
Length of output: 1581
Script:
#!/bin/bash
# Let's check the repository's Renovate configuration files directly
gh api repos/5ouma/utils/contents/renovate.json || echo "renovate.json not found"
gh api repos/5ouma/utils/contents/.github/renovate.json || echo ".github/renovate.json not found"
gh api repos/5ouma/utils/contents/.renovaterc.json || echo ".renovaterc.json not found"
# Also check for any preset files in common locations
gh api repos/5ouma/utils/contents/presets || echo "presets directory not found"
gh api repos/5ouma/utils/contents/.github/presets || echo ".github/presets directory not found"
Length of output: 2124
Script:
#!/bin/bash
# Let's decode and examine the content of the found renovate.json
echo "ewogICIkc2NoZW1hIjogImh0dHBzOi8vZG9jcy5yZW5vdmF0ZWJvdC5jb20vcmVub3ZhdGUtc2NoZW1hLmpzb24iLAogICJleHRlbmRzIjogWyJnaXRodWI+NW91bWEvdXRpbHMiXSwKICAicHJlLWNvbW1pdCI6IHsgImVuYWJsZWQiOiB0cnVlIH0KfQo=" | base64 -d
# Let's also check for any default presets in the repository
gh api repos/5ouma/utils/contents/default.json || echo "default.json not found"
gh api repos/5ouma/utils/contents/.github/default.json || echo ".github/default.json not found"
gh api repos/5ouma/utils/contents/labels.json || echo "labels.json not found"
gh api repos/5ouma/utils/contents/.github/labels.json || echo ".github/labels.json not found"
Length of output: 3249
close #
✏️ Description
Default and GitHub Actions labels will be added.
🔄 Type of the Change
Code of Conduct.