Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename test file postfix #45

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Rename test file postfix #45

merged 3 commits into from
Aug 27, 2024

Conversation

5ouma
Copy link
Owner

@5ouma 5ouma commented Aug 27, 2024

⚠️ Issue

close #


🔄 Type of the Change

  • 🎉 New Feature
  • 🧰 Bug
  • 🛡️ Security
  • 📖 Documentation
  • 🏎️ Performance
  • 🧹 Refactoring
  • 🧪 Testing
  • 🔧 Maintenance
  • 🎽 CI
  • ⛓️ Dependencies
  • 🧠 Meta

✏️ Description

  • The TS test file name usually ends with .test.ts
  • Remove the JSON schema
  • Add a new line between the JSR and local import

5ouma added 3 commits August 27, 2024 20:46
Customarily, TS test file name ends with `.test.ts`.
It's not needed to refer the types.
It makes the code clear for JSR and local import.
@prlabeler prlabeler bot added the 🧹 Refactoring A code change that neither fixes a bug nor adds a feature label Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6687934) to head (1f59560).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev       #45   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         7    +1     
  Lines           97        98    +1     
  Branches        10        11    +1     
=========================================
+ Hits            97        98    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@5ouma 5ouma merged commit cc8d3cc into dev Aug 27, 2024
10 checks passed
@5ouma 5ouma deleted the refactor-files branch August 27, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 Refactoring A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant