-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.12 Support, Drop Python 3.7 #253
Conversation
…ment. Also dropped Python 3.7
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #253 +/- ##
==========================================
- Coverage 97.12% 96.92% -0.21%
==========================================
Files 42 42
Lines 1498 1498
==========================================
- Hits 1455 1452 -3
- Misses 43 46 +3 ☔ View full report in Codecov by Sentry. |
Is this repository / project dead? Is there a replacement project? |
This branch works well on my side. |
Someone made one: https://github.com/henriquegemignani/PyQtDarkTheme. The issues tab isn't open though. |
Hi @henriquegemignani, I see you included this PR in your fork and published it on PyPI. Are you interested in maintaining that fork, and accepting issues and PRs? It seems like there are others here (including myself) who are willing to help keep this going. |
If you open a PR I'm ok with merging and releasing, but I don't plan on doing more than maintenance that lets me keep upgrading PySide and Python. |
That's fair. Thanks for the reply! |
@henriquegemignani Could you enable issues on your repo? |
@mak448a Sure, but I don't really see an use. |
@woopelderly can you please update the package constraints to allow python 3.13 too? |
@yshalsager, It looks like Python 3.12 and newer is being supported in a fork here: https://github.com/henriquegemignani/PyQtDarkTheme. |
fix #252
Update to support Python 3.12. To do this I also had to update pre-commit from 2.20 to 3.5 because of packaging methods that were removed in Python 3.12; specifically Python 3.12 removed the deprecated
ImpImporter
frompgkutil
.Drop Python 3.7 support because pre-commit 3.5 does not support Python 3.7.
The poetry.lock file was regenerated from within the Python 3.12 virtual environment.