Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 Support, Drop Python 3.7 #253

Closed
wants to merge 7 commits into from

Conversation

woopelderly
Copy link

@woopelderly woopelderly commented Nov 16, 2023

fix #252

  • Update to support Python 3.12. To do this I also had to update pre-commit from 2.20 to 3.5 because of packaging methods that were removed in Python 3.12; specifically Python 3.12 removed the deprecated ImpImporter from pgkutil.

  • Drop Python 3.7 support because pre-commit 3.5 does not support Python 3.7.

  • The poetry.lock file was regenerated from within the Python 3.12 virtual environment.

@woopelderly
Copy link
Author

pre-commit.ci autofix

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (96eb7e3) 97.12% compared to head (bbcf4d5) 96.92%.

❗ Current head bbcf4d5 differs from pull request most recent head dcab630. Consider uploading reports for the commit dcab630 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
- Coverage   97.12%   96.92%   -0.21%     
==========================================
  Files          42       42              
  Lines        1498     1498              
==========================================
- Hits         1455     1452       -3     
- Misses         43       46       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyleboyle
Copy link

Is this repository / project dead? Is there a replacement project?

@fgervais
Copy link

This branch works well on my side.

@mak448a
Copy link

mak448a commented Aug 7, 2024

Is this repository / project dead? Is there a replacement project?

Someone made one: https://github.com/henriquegemignani/PyQtDarkTheme. The issues tab isn't open though.

@JWCook
Copy link

JWCook commented Aug 13, 2024

Hi @henriquegemignani, I see you included this PR in your fork and published it on PyPI. Are you interested in maintaining that fork, and accepting issues and PRs? It seems like there are others here (including myself) who are willing to help keep this going.

@henriquegemignani
Copy link
Contributor

If you open a PR I'm ok with merging and releasing, but I don't plan on doing more than maintenance that lets me keep upgrading PySide and Python.

@JWCook
Copy link

JWCook commented Aug 13, 2024

That's fair. Thanks for the reply!

@mak448a
Copy link

mak448a commented Aug 13, 2024

@henriquegemignani Could you enable issues on your repo?

@henriquegemignani
Copy link
Contributor

@mak448a Sure, but I don't really see an use.

@yshalsager
Copy link

@woopelderly can you please update the package constraints to allow python 3.13 too?

@woopelderly
Copy link
Author

@yshalsager, It looks like Python 3.12 and newer is being supported in a fork here: https://github.com/henriquegemignani/PyQtDarkTheme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.12 Support
7 participants