Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kind of liked how the non-
_hmac
pbkdf2 function reads a little more, but now you have to call.expect
on theResult
that it now returns (it used to unwrap it for us internally). Using thepbkdf2_hmac
function requires thehmac
feature to be enabled for thepbkdf2
crate, which means we no longer need thehmac
crate sincepbkdf2
re-exports it.I was going to run
cargo update
to updateCargo.lock
as well, but quickly realized it would be a pain to properly review. Do let me know if you want me to commit that, too.