Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies #10

Merged
merged 1 commit into from
Feb 2, 2024
Merged

update dependencies #10

merged 1 commit into from
Feb 2, 2024

Conversation

ccptr
Copy link
Contributor

@ccptr ccptr commented Feb 1, 2024

I kind of liked how the non-_hmac pbkdf2 function reads a little more, but now you have to call .expect on the Result that it now returns (it used to unwrap it for us internally). Using the pbkdf2_hmac function requires the hmac feature to be enabled for the pbkdf2 crate, which means we no longer need the hmac crate since pbkdf2 re-exports it.

I was going to run cargo update to update Cargo.lock as well, but quickly realized it would be a pain to properly review. Do let me know if you want me to commit that, too.

@71
Copy link
Owner

71 commented Feb 2, 2024

Thanks!

Using the pbkdf2_hmac function requires the hmac feature to be enabled for the pbkdf2 crate, which means we no longer need the hmac crate since pbkdf2 re-exports it.

It re-exports the crate but it still feels like one less dependency, which is good.

I was going to run cargo update to update Cargo.lock as well, but quickly realized it would be a pain to properly review. Do let me know if you want me to commit that, too.

Thanks for your consideration. It's fine as it is.

@71 71 merged commit c67b583 into 71:master Feb 2, 2024
3 checks passed
@ccptr
Copy link
Contributor Author

ccptr commented Feb 5, 2024

Thanks for maintaining the crate! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants