Feat: 로그인 모달 UI 구현 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParkSohyunee
requested review from
Eugene-A-01,
kanglocal,
Nahyun-Kang and
seoyoung-min
|
@ParkSohyunee is attempting to deploy a commit to the Eujin Ahn's projects Team on Vercel. A member of the Team first needs to authorize it. |
ParkSohyunee
commented
Feb 15, 2024
Comment on lines
8
to
16
| interface ModalMainProps { | ||
| size?: 'basic' | 'large'; | ||
| children?: ReactNode; | ||
| handleModalClose: () => void; | ||
| } | ||
|
|
||
| function ModalMain({ children, handleModalClose }: ModalMainProps) { | ||
| function ModalMain({ size = 'basic', children, handleModalClose }: ModalMainProps) { | ||
| const { ref } = useOnClickOutside(() => { | ||
| handleModalClose(); |
There was a problem hiding this comment.
(참고) 현재 size가 옵셔널로 되어있는데, 기존 모달을 사용하는 코드에서 size prop을 모두 지정후에 옵셔널을 지울 생각입니다!
seoyoung-min
approved these changes
Feb 16, 2024
Comment on lines
+30
to
+32
| interface SizeVariantsType { | ||
| [key: string]: ComplexStyleRule; | ||
| } |
Nahyun-Kang
approved these changes
Feb 16, 2024
Nahyun-Kang
reviewed
Feb 16, 2024
| }} | ||
| > | ||
| <button onClick={() => handleSetOn()}> | ||
| 누르면 로그인 모달 등장 |
Nahyun-Kang
reviewed
Feb 16, 2024
| </div> | ||
| </div> | ||
| <div className={styles.buttonContainer}> | ||
| <Link href={`${baseUrl}/auth/${oauthType.naver}`}> |
There was a problem hiding this comment.
와... 저도 링크 쓸 수 있는 건 그냥 링크 써도 됐는데.. 완전 까먹고 있었어요👀 감사합니다..!
Nahyun-Kang
reviewed
Feb 16, 2024
| export const text = style({ | ||
| color: vars.color.black, | ||
|
|
||
| // TODO Body Regular로 변경하기 |
There was a problem hiding this comment.
todo란 이렇게 쓰는 것이다.. 메모메모
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업 사항
참고 사항 (optional)
스크린샷
ㄴ 로그인 후 현재는 탐색페이지(/)로 이동하지만, 로그인을 시도했던 페이지로 이동하도록 수정 예정
ㄴ 리다이렉트 페이지로 이동하면서 모달은 자동으로 닫힘
리뷰어에게