Infra: 프론트엔드 개발 서버 CI/CD 구축 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdkdhoho
requested review from
Eugene-A-01,
kanglocal,
ParkSohyunee and
Nahyun-Kang
kanglocal
approved these changes
Jan 26, 2024
seoyoung-min
approved these changes
Jan 26, 2024
ParkSohyunee
approved these changes
Jan 26, 2024
Nahyun-Kang
approved these changes
Jan 26, 2024
kdkdhoho
requested review from
Eugene-A-01
and removed request for
Eugene-A-01
치킨은 오늘 제가 맛있게 먹도록 하겠습니다 |
|
|
||
| - name: S3 and CloudFront Deploy | ||
| uses: Reggionick/s3-deploy@v4 | ||
| with: |
There was a problem hiding this comment.
어쩌다 CI/CD 관련 글을 보다가, 다시 한 번 옵션들을 살펴보았습니다! 여기에서 delete-removed: true 옵션은 필요 없을까요??
"delete-removed: Removes files in S3, that are not available in the local copy of the directory" - Reggionick/s3-deploy
"로컬에서 삭제한 파일이 S3에서도 자동으로 삭제되므로, 불필요한 파일을 자동으로 정리할 수 있습니다. 하지만 주의하여 사용해야 합니다. 실수로 중요한 파일을 삭제하지 않도록 주의해야 합니다." - Chat GPT
There was a problem hiding this comment.
제가 이해하기로 해당 옵션이 Github Repository(local)에서 지운 파일에 대해서 S3에도 동일하게 제거하는 옵션인건가요??
There was a problem hiding this comment.
그러면 아무래도 옵션을 키는게 좋겠네요! 감사합니다 👍👍👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
dev브랜치에 해당하는, 프론트엔드 개발 서버의 CI/CD 구축 완료 했습니다!보안을 강화하거나 성능 개선 할 여지가 있지만 둘 다 차차 진행하도록 하겠습니다!
작업 사항
참고 사항 (optional)
이건 불편함을 느끼실 때 다시 작업하는 걸로 하겠습니다!
관련 이슈 (optional)
스크린샷
리뷰어에게