updated test cases to resolve linting issues in them

99designs · Dec 9, 2024 · 2fbba69 · 2fbba69
1 parent ab37f57
commit 2fbba69
Show file tree

Hide file tree

Showing 3 changed files with 39 additions and 6 deletions.
diff --git a/.github/workflows/check-coverage b/.github/workflows/check-coverage
@@ -7,4 +7,29 @@ go test -covermode atomic -coverprofile=/tmp/coverage.out.tmp -coverpkg=./... $(
 # ignore protobuf files
 cat /tmp/coverage.out.tmp | grep -v ".pb.go" > /tmp/coverage.out
 
-goveralls -coverprofile=/tmp/coverage.out -service=github -ignore='_examples/*/*,_examples/*/*/*,integration/*,integration/*/*,codegen/testserver/*/*,plugin/resolvergen/testdata/*/*,plugin/modelgen/*/*,plugin/federation/testdata/*/*/*,*/generated.go,*/*/generated.go,*/*/*/generated.go,graphql/executable_schema_mock.go'
+join () {
+  local IFS="$1"
+  shift
+  echo "$*"
+}
+
+ignore_list=(
+  '_examples/*/*'
+  '_examples/*/*/*'
+  'integration/*'
+  'integration/*/*'
+  'codegen/testserver/**/*generated*'
+  'codegen/testserver/**/*generated*/**'
+  'codegen/testserver/**/models-gen.go'
+  'codegen/testserver/**/resolver.go'
+  'plugin/resolvergen/testdata/*/*'
+  'plugin/modelgen/*/*'
+  'plugin/federation/testdata/*/*/*'
+  '*/generated.go'
+  '*/*/generated.go'
+  '*/*/*/generated.go'
+  'graphql/executable_schema_mock.go'
+)
+ignore=$(join , "${ignore_list[@]}")
+
+goveralls -coverprofile=/tmp/coverage.out -service=github "-ignore=$ignore"
diff --git a/codegen/testserver/usefunctionsyntaxforexecutioncontext/generated_test.go b/codegen/testserver/usefunctionsyntaxforexecutioncontext/generated_test.go
@@ -8,6 +8,7 @@ import (
 	"encoding/json"
 	"testing"
 
+	"github.com/99designs/gqlgen/graphql/handler/transport"
 	"github.com/stretchr/testify/require"
 
 	"github.com/99designs/gqlgen/client"
@@ -16,12 +17,13 @@ import (
 
 func TestQuery(t *testing.T) {
 	resolvers := &Stub{}
-	srv := handler.NewDefaultServer(NewExecutableSchema(Config{
+	srv := handler.New(NewExecutableSchema(Config{
 		Resolvers: resolvers,
 		Directives: DirectiveRoot{
 			Log: LogDirective,
 		},
 	}))
+	srv.AddTransport(transport.POST{})
 	c := client.New(srv)
 
 	testAge := new(int)
@@ -139,12 +141,13 @@ func TestQuery(t *testing.T) {
 
 func TestMutation(t *testing.T) {
 	resolvers := &Stub{}
-	srv := handler.NewDefaultServer(NewExecutableSchema(Config{
+	srv := handler.New(NewExecutableSchema(Config{
 		Resolvers: resolvers,
 		Directives: DirectiveRoot{
 			Log: LogDirective,
 		},
 	}))
+	srv.AddTransport(transport.POST{})
 	c := client.New(srv)
 
 	createdAt := "2021-01-01"
@@ -224,12 +227,13 @@ func TestMutation(t *testing.T) {
 
 func TestSubscription(t *testing.T) {
 	resolvers := &Stub{}
-	srv := handler.NewDefaultServer(NewExecutableSchema(Config{
+	srv := handler.New(NewExecutableSchema(Config{
 		Resolvers: resolvers,
 		Directives: DirectiveRoot{
 			Log: LogDirective,
 		},
 	}))
+	srv.AddTransport(transport.POST{})
 	c := client.New(srv)
 
 	createdAt := "2021-01-01"

diff --git a/plugin/federation/federation_use_function_syntax_for_execution_context_test.go b/plugin/federation/federation_use_function_syntax_for_execution_context_test.go
@@ -4,6 +4,7 @@ package federation
 import (
 	"testing"
 
+	"github.com/99designs/gqlgen/graphql/handler/transport"
 	"github.com/stretchr/testify/require"
 
 	"github.com/99designs/gqlgen/client"
@@ -13,11 +14,14 @@ import (
 )
 
 func TestFederationWithUseFunctionSyntaxForExecutionContext(t *testing.T) {
-	c := client.New(handler.NewDefaultServer(
+	srv := handler.New(
 		generated.NewExecutableSchema(generated.Config{
 			Resolvers: &usefunctionsyntaxforexecutioncontext.Resolver{},
 		}),
-	))
+	)
+	srv.AddTransport(transport.POST{})
+	c := client.New(srv)
+
 
 	t.Run("Hello entities", func(t *testing.T) {
 		representations := []map[string]any{