Adding duration scalar conforming to ISO8601 standard

[rwrz]

I'm adding the Duration scalar following the ISO8601 standard, which converts to a time.Duration in Go.

I have:

• Added tests covering the bug / feature (see testing)
• Updated any relevant documentation (see docs)

[coveralls]

coverage: 79.616% (+3.5%) from 76.101% when pulling d7f2f75 on rwrz:duration_scalar into 37f8e4e on 99designs:master.

[StevenACoffman]

Hey, so it looks like there are some lint and test failures in your PR. I don't usually review these PRs until after they pass all the checks.

One failure is just that the import statements of your test file are not sorted.

It looks like you also need to run go mod tidy to download the dependency in the _examples directory, as that is another module.

You also might need to run:

go generate ./...; cd _examples; go generate ....

[rwrz]

Thank you. I will have a look at this tomorrow.
I've changed this scalar a little bit as well, using more the StringMarshaler. I will update it soon

[StevenACoffman]

@rwrz Hey, can you give this another pass?

[it512]

I'll take the job

[rwrz]

I've updated the code, now using MarshalString, so it now adds the double quotes to the String.

[rwrz]

go test ./...
passes now... it was missing the new Duration deps as you mentioned.

[StevenACoffman]

Thanks! This is handy. I would prefer not to add dependencies, but this is pretty small, and certmanager uses it, so that makes me feel better.

[it512]

good!