Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use fmt.Sprintf for better readability #3345

Merged
merged 1 commit into from
Oct 24, 2024
Merged

refactor: use fmt.Sprintf for better readability #3345

merged 1 commit into from
Oct 24, 2024

Conversation

alexandear
Copy link
Contributor

The PR refactors Directive.CallArgs implementation by using fmt.Sprintf instead of strings concatenation.

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@coveralls
Copy link

Coverage Status

coverage: 59.31% (+0.06%) from 59.248%
when pulling ea64cbb on alexandear:refactor/simplify-directive-callargs
into 4367bb9 on 99designs:master.

@alexandear alexandear changed the title refactor: use fmt.Sprintf for improve readability refactor: use fmt.Sprintf for better readability Oct 24, 2024
@StevenACoffman StevenACoffman merged commit 6cad444 into 99designs:master Oct 24, 2024
16 of 17 checks passed
@alexandear alexandear deleted the refactor/simplify-directive-callargs branch October 24, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandear @coveralls @StevenACoffman