Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix union queries not working in @requires #3347

Merged
merged 8 commits into from
Oct 30, 2024

Conversation

rickbijkerk
Copy link
Contributor

fixes: #3342

also tested in our project and its working ; )

I have:

  • [x ] Added tests covering the bug / feature (see testing)
  • [x ] Updated any relevant documentation (see docs)

@StevenACoffman StevenACoffman added the federation Related to Apollo federation label Oct 28, 2024
@coveralls
Copy link

coveralls commented Oct 28, 2024

Coverage Status

coverage: 59.216% (-0.06%) from 59.279%
when pulling 3f1ce68 on rickbijkerk:master
into 6cad444 on 99designs:master.

@clayne11
Copy link
Contributor

clayne11 commented Oct 28, 2024

explicit_requires is deprecated — did you test using computed_requires and does this issue still occur with that config flag enabled?

@rickbijkerk
Copy link
Contributor Author

yes, also tried it with computed_requires same issue occurs there

@clayne11
Copy link
Contributor

Got it, thanks. I believe this code is not really used in the computed_requires flow but it is still executed until we fully remove the explicit_requires code path. Thanks for the fix.

@StevenACoffman
Copy link
Collaborator

@rickbijkerk Hey, can you run:

go generate ./...

Thanks for this!

@StevenACoffman StevenACoffman merged commit 7b2e27b into 99designs:master Oct 30, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
federation Related to Apollo federation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@requires fields unable to deal with Union
4 participants