Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch incremental deferred responses. Fix hanging behavior on last response #3357

Conversation

giulio-opal
Copy link
Contributor

Iterate on my previous PR: #3341
Few changes:

This PR also works correctly with #3356

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@giulio-opal giulio-opal force-pushed the giulio/batch-incremental-responses-multipart-mixed branch from b4100e1 to 0578697 Compare November 4, 2024 20:27
@coveralls
Copy link

Coverage Status

coverage: 59.385% (+0.1%) from 59.284%
when pulling 0578697 on giulio-opal:giulio/batch-incremental-responses-multipart-mixed
into 41a7be2 on 99designs:master.

@StevenACoffman StevenACoffman added websocket federation Related to Apollo federation SSE Server-Sent Events apollo labels Nov 5, 2024
@StevenACoffman StevenACoffman merged commit df59e59 into 99designs:master Nov 5, 2024
16 of 17 checks passed
@StevenACoffman
Copy link
Collaborator

Thank you!

@StevenACoffman StevenACoffman added the defer-or-stream Related to GraphQL @defer or @stream directives label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apollo defer-or-stream Related to GraphQL @defer or @stream directives federation Related to Apollo federation SSE Server-Sent Events websocket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants