Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update golangci-lint to v1.62.0 #3386

Merged

Conversation

alexandear
Copy link
Contributor

The PR upgrades the version for golangci-lint to the latest v1.62.0.

Additionally, fixes these new lint issues:

❯ golangci-lint run
handler/handler.go:107:18: redefines-builtin-id: redefinition of the built-in function recover (revive)
func RecoverFunc(recover graphql.RecoverFunc) Option {
                 ^
codegen/testserver/followschema/directive_test.go:115:70: redefines-builtin-id: redefinition of the built-in function min (revive)
                        Length: func(ctx context.Context, obj any, next graphql.Resolver, min int, max *int, message *string) (any, error) {
                                                                                          ^
codegen/testserver/followschema/directive_test.go:136:69: redefines-builtin-id: redefinition of the built-in function min (revive)
                        Range: func(ctx context.Context, obj any, next graphql.Resolver, min *int, max *int) (any, error) {
                                                                                         ^
codegen/testserver/singlefile/directive_test.go:115:70: redefines-builtin-id: redefinition of the built-in function min (revive)
                        Length: func(ctx context.Context, obj any, next graphql.Resolver, min int, max *int, message *string) (any, error) {
                                                                                          ^

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@alexandear alexandear force-pushed the chore/upgate-golangci-lint branch from cd4fb99 to e9987e9 Compare November 24, 2024 18:20
@alexandear alexandear force-pushed the chore/upgate-golangci-lint branch from e9987e9 to ddf9e89 Compare November 24, 2024 18:20
@coveralls
Copy link

Coverage Status

coverage: 59.753%. remained the same
when pulling ddf9e89 on alexandear:chore/upgate-golangci-lint
into de7923e on 99designs:master.

@StevenACoffman
Copy link
Collaborator

I don't know what I did to deserve your periodic cleanups, but I really appreciate it! Thanks again!

@StevenACoffman StevenACoffman merged commit 8a5f927 into 99designs:master Nov 24, 2024
16 of 17 checks passed
@alexandear
Copy link
Contributor Author

I don't know what I did to deserve your periodic cleanups, but I really appreciate it! Thanks again!

I'm happy to improve this tool as we are using it in our commercial project.

@alexandear alexandear deleted the chore/upgate-golangci-lint branch November 25, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants