Merge pull request #48 from karenstemartins/bug_fisher_chi2

bug in hypothesis definition fisher and chi2
A3Data · Sep 14, 2021 · 67d9dfc · 67d9dfc
2 parents d77b637 + 7fcbfc3
commit 67d9dfc
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/hermione/module_templates/__IMPLEMENTED_BASE__/src/ml/analysis/hypothesis_testing.py b/hermione/module_templates/__IMPLEMENTED_BASE__/src/ml/analysis/hypothesis_testing.py
@@ -201,8 +201,8 @@ def fisher_exact_test(df, sample1, sample2, alpha=0.05,
         pd.DataFrame
         """
         hypothesis = {
-          'two-sided_H0': "the samples are dependent",
-          'two-sided_H1': "the samples are independent",
+          'two-sided_H0': "the samples are independent",
+          'two-sided_H1': "the samples are dependent",
         }
         table = pd.crosstab(df[sample1], df[sample2])
         statistic, p_value = fisher_exact(table, 'two-sided')
@@ -252,8 +252,8 @@ def chi2_test(df, sample1, sample2, correction=True, alpha=0.05,
         pd.DataFrame
         """
         hypothesis = {
-          'two-sided_H0': "the samples are dependent",
-          'two-sided_H1': "the samples are independent"
+          'two-sided_H0': "the samples are independent",
+          'two-sided_H1': "the samples are dependent"
         }
         expected, observed, stats = pg.chi2_independence(df, sample1, sample2,
                                                          correction)

diff --git a/hermione/module_templates/__IMPLEMENTED_SAGEMAKER__/src/ml/analysis/hypothesis_testing.py b/hermione/module_templates/__IMPLEMENTED_SAGEMAKER__/src/ml/analysis/hypothesis_testing.py
@@ -201,8 +201,8 @@ def fisher_exact_test(df, sample1, sample2, alpha=0.05,
         pd.DataFrame
         """
         hypothesis = {
-          'two-sided_H0': "the samples are dependent",
-          'two-sided_H1': "the samples are independent",
+          'two-sided_H0': "the samples are independent",
+          'two-sided_H1': "the samples are dependent",
         }
         table = pd.crosstab(df[sample1], df[sample2])
         statistic, p_value = fisher_exact(table, 'two-sided')
@@ -252,8 +252,8 @@ def chi2_test(df, sample1, sample2, correction=True, alpha=0.05,
         pd.DataFrame
         """
         hypothesis = {
-          'two-sided_H0': "the samples are dependent",
-          'two-sided_H1': "the samples are independent"
+          'two-sided_H0': "the samples are independent",
+          'two-sided_H1': "the samples are dependent"
         }
         expected, observed, stats = pg.chi2_independence(df, sample1, sample2,
                                                          correction)

diff --git a/hermione/module_templates/__NOT_IMPLEMENTED_BASE__/src/ml/analysis/hypothesis_testing.py b/hermione/module_templates/__NOT_IMPLEMENTED_BASE__/src/ml/analysis/hypothesis_testing.py
@@ -201,8 +201,8 @@ def fisher_exact_test(df, sample1, sample2, alpha=0.05,
         pd.DataFrame
         """
         hypothesis = {
-          'two-sided_H0': "the samples are dependent",
-          'two-sided_H1': "the samples are independent",
+          'two-sided_H0': "the samples are independent",
+          'two-sided_H1': "the samples are dependent",
         }
         table = pd.crosstab(df[sample1], df[sample2])
         statistic, p_value = fisher_exact(table, 'two-sided')
@@ -252,8 +252,8 @@ def chi2_test(df, sample1, sample2, correction=True, alpha=0.05,
         pd.DataFrame
         """
         hypothesis = {
-          'two-sided_H0': "the samples are dependent",
-          'two-sided_H1': "the samples are independent"
+          'two-sided_H0': "the samples are independent",
+          'two-sided_H1': "the samples are dependent"
         }
         expected, observed, stats = pg.chi2_independence(df, sample1, sample2,
                                                          correction)