Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exchange Focus Effect Sound Revamp #482

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Exchange Focus Effect Sound Revamp #482

merged 1 commit into from
Jun 7, 2024

Conversation

IcarussOne
Copy link
Contributor

This was the only focus effect that wasn't affected by the sound tweak so I went ahead and fixed that.

Copy link

what-the-diff bot commented Jun 7, 2024

PR Summary

  • Enhancements to the 'UTConfigMods' Class
    Two new features are provided to improve the user experience within an application feature called the 'Exchange'. The new revisions are:

    • 'Exchange: Cast Sound Revamp' - This improvement significantly upgrades the audio that is played whenever the exchange focus effect is activated.
    • 'Exchange: Impact Sound' - This addition introduces a new sound effect that plays when the exchange focus effect impacts something.
  • Addition of 'UTExchangeFocusMixin.java'

    • A new file 'UTExchangeFocusMixin.java' was added. This is an important new component that specifically affects an in-game effect called the 'Exchange'. It was created to further improve the audio experience of this feature by introducing a new 'cast sound' and a 'impact sound'.
  • Modifications to 'mixins.mods.thaumcraft.foci.focuseffects.json'

    • The just-introduced 'UTExchangeFocusMixin' was included in a master list ('mixins.mods.thaumcraft.foci.focuseffects.json'). This list determines what modules will be active in the Thaumcraft's 'focus effects'. These sets of changes ensure that our new audio upgrades are employed effectively within the game.

@ACGaming ACGaming merged commit da5a016 into ACGaming:main Jun 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants