Test bitcoind wallet behavior during mempool eviction #2817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When transactions are being evicted from the mempool, we want to make sure that bitcoind keeps the corresponding wallet inputs locked to avoid accidentally double-spending ourselves. We update our unit test to be closer to common scenarios (chain of unconfirmed splice txs and commit txs replaced by the remote version). This test confirms that bitcoind keeps wallet inputs locked, and we have to call `abandontransaction` to free up utxos used in txs that have been permanently double-spent.
t-bast
force-pushed
the
bitcoind-pruning-tests
branch
from
01acbbc to
57f3242
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2817 +/- ##
==========================================
+ Coverage 85.86% 85.90% +0.04%
==========================================
Files 216 217 +1
Lines 18228 18296 +68
Branches 772 793 +21
==========================================
+ Hits 15652 15718 +66
- Misses 2576 2578 +2
|
When one of our wallet transactions is directly double-spent, the bitcoin wallet detects that and automatically frees up wallet inputs from the permanently double-spent wallet transaction. This is great, that means we only need to manually call `abandontransaction` for transactions that have been invalidated because one of their parents has been double-spent.
t-bast
force-pushed
the
bitcoind-pruning-tests
branch
from
6b5a770 to
ae0c312
Compare
pm47
reviewed
Feb 13, 2024
eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientSpec.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientSpec.scala
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientSpec.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientSpec.scala
Outdated
Show resolved
Hide resolved
pm47
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When transactions are being evicted from the mempool, we want to make sure that bitcoind keeps the corresponding wallet inputs locked to avoid accidentally double-spending ourselves. We update our unit tests to be closer to common scenarios (chain of unconfirmed splice txs, commit txs replaced by the remote version, anchor tx RBF and htlc txs conflicts).
These tests confirm that:
abandontransactionourselves to free up utxos