Move recommended_feerates message to CONNECTED state
#2984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously handled `recommended_feerates` in our `whenUnhandled` handler, but that doesn't work since we have a catch-all handler in the `CONNECTED` state for all known lightning messages. We thus move this handler into the `CONNECTED` state to avoid warnings in the logs.
sstone
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously handled
recommended_feeratesin ourwhenUnhandledhandler, but that doesn't work since we have a catch-all handler in theCONNECTEDstate for all known lightning messages. We thus move this handler into theCONNECTEDstate to avoid warnings in the logs.