Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not estimate balance for local channels #2988

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

thomash-acinq
Copy link
Member

We already know th balance of local channels, we don't need to estimate it.

We already know th balance of local channels, we don't need to estimate it.
@thomash-acinq thomash-acinq requested a review from t-bast January 28, 2025 20:30
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.98%. Comparing base (12df4ce) to head (cd3125a).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2988      +/-   ##
==========================================
- Coverage   86.02%   85.98%   -0.04%     
==========================================
  Files         227      227              
  Lines       20371    20374       +3     
  Branches      815      846      +31     
==========================================
- Hits        17524    17519       -5     
- Misses       2847     2855       +8     
Files with missing lines Coverage Δ
...scala/fr/acinq/eclair/router/BalanceEstimate.scala 97.24% <100.00%> (-1.84%) ⬇️

... and 8 files with indirect coverage changes

Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's see how this behaves now that we're ignoring local channels.

@thomash-acinq thomash-acinq merged commit 73ea751 into master Jan 29, 2025
1 check passed
@thomash-acinq thomash-acinq deleted the local-balance branch January 29, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants