Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prohibit using the * symbol to approve all types of tokens #3568

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

eanzhao
Copy link
Contributor

@eanzhao eanzhao commented Jun 24, 2024

For Issue: #3567

Copy link

vizipi bot commented Jun 24, 2024

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
100.00% jason-hoopox 21 4
100.00% ssun0121 11 4
100.00% ZhangXin 11 4
100.00% Stephen02Zhang 1 4
75.00% louis.li 37 3
75.00% Stephen01Zhang 18 3

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
contract/AElf.Contracts.MultiToken/TokenContract_Actions.cs81.82%9 out of 11 times
protobuf/token_contract.proto81.82%9 out of 11 times
...contract/AElf.Contracts.MultiToken/TokenContractConstants81.82%9 out of 11 times
contract/AElf.Contracts.MultiToken/TokenContract_Fees.cs54.55%6 out of 11 times
...test/AElf.Contracts.MultiToken.Tests/BVT/TokenManagementT45.45%5 out of 11 times
...test/AElf.Contracts.Economic.TestBase/ContractsPreparatio45.45%5 out of 11 times

Committed file ranks

(click to expand)
  • 99.60%[contract/AElf.Contracts.MultiToken/TokenContract_Views.cs]
  • 98.02%[...contract/AElf.Contracts.MultiToken/TokenContract_NFT_Acti]
  • 99.78%[contract/AElf.Contracts.MultiToken/TokenContract_Helper.cs]
  • 99.10%[...test/AElf.Contracts.MultiToken.Tests/BVT/TokenApplication]
  • Copy link

    codecov bot commented Jun 24, 2024

    Codecov Report

    Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

    Project coverage is 90.68%. Comparing base (c74f23e) to head (fc35ced).

    Additional details and impacted files

    Impacted file tree graph

    @@            Coverage Diff             @@
    ##              dev    #3568      +/-   ##
    ==========================================
    - Coverage   90.70%   90.68%   -0.03%     
    ==========================================
      Files         668      668              
      Lines       25895    25881      -14     
      Branches     2325     2323       -2     
    ==========================================
    - Hits        23489    23471      -18     
    - Misses       2290     2294       +4     
      Partials      116      116              
    Files Coverage Δ
    ....Contracts.MultiToken/TokenContract_NFT_Actions.cs 91.26% <100.00%> (-0.85%) ⬇️
    ...t/AElf.Contracts.MultiToken/TokenContract_Views.cs 89.04% <100.00%> (-1.91%) ⬇️
    .../AElf.Contracts.MultiToken/TokenContract_Helper.cs 85.95% <75.00%> (-0.15%) ⬇️

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant