Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update StatusV2 to StatusWithBVP #3628

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

JimAelf
Copy link
Collaborator

@JimAelf JimAelf commented Dec 7, 2024

For issue: #3623

Copy link

vizipi bot commented Dec 7, 2024

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
100.00% jason-hoopox 41 3
66.67% ZhangXin 16 2
66.67% eanzhao 10 2
66.67% zhifenglee-portkey 1 2
33.33% gldeng 6 1
33.33% louis.li 6 1

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
protobuf/kernel.proto60.00%9 out of 15 times
test/AElf.OS.TestBase/OSTestHelper.cs50.00%2 out of 4 times
protobuf/aelf/core.proto50.00%2 out of 4 times

Committed file ranks

(click to expand)
  • 79.70%[...src/AElf.WebApp.Application.Chain/Dto/TransactionResultDt]
  • 95.30%[...src/AElf.WebApp.Application.Chain/Services/TransactionRes]
  • 99.80%[...test/AElf.WebApp.Application.Chain.Tests/BlockChainAppSer]
  • Copy link

    codecov bot commented Dec 7, 2024

    Codecov Report

    All modified and coverable lines are covered by tests ✅

    Project coverage is 73.24%. Comparing base (a74faf0) to head (2a62de2).
    Report is 2 commits behind head on dev.

    Additional details and impacted files

    Impacted file tree graph

    @@           Coverage Diff           @@
    ##              dev    #3628   +/-   ##
    =======================================
      Coverage   73.24%   73.24%           
    =======================================
      Files         678      678           
      Lines       26209    26209           
      Branches     2364     2364           
    =======================================
      Hits        19196    19196           
      Misses       6857     6857           
      Partials      156      156           
    Files with missing lines Coverage Δ
    ...tion.Chain/Services/TransactionResultAppService.cs 0.00% <ø> (ø)

    @JimAelf JimAelf merged commit 187d3ed into dev Dec 7, 2024
    11 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants