Regarding the release PR for aelf project version 1.12.0 #3630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eature/whitelist-to-sdk
2. Add an execution limit for inline transactions 3. Improve compatibility in inline method validation.
…optimize Transaction status result optimization
…ion-time Extend seed NFT expiration time
TransactionResult optimization
…optimize Merge pull request #3626 from AElfProject/dev
…nt of Extend seed expiration time
…status-modify update StatusV2 to StatusWithBVP
Add a new whitelist solution
|
Pull request analysis by VIZIPI Below you will find who is the most qualified team member to review your code. Reviewers with knowledge related to these changes
Potential missing files from this Pull requestNo commonly committed files found with a 40% threashold Committed file ranks(click to expand)51.92%[...test/AElf.Kernel.Core.Tests/Extensions/TransactionExtensi] 58.37%[...src/AElf.Sdk.CSharp.Internal/AElf.Sdk.CSharp.Internal.csp] 0.00%[src/AElf.Runtime.CSharp/TransactionConsts.cs] 90.80%[global.json] 98.57%[AElf.All.sln] 99.38%[...contract/AElf.Contracts.Consensus.AEDPoS/AEDPoSContract_P] 95.99%[...src/AElf.CSharp.CodeOps/Validators/Whitelist/IWhitelistPr] 82.87%[src/AElf.Runtime.CSharp.Core/ContractCodeLoadContext.cs] 97.66%[...src/AElf.Kernel.SmartContract/AElf.Kernel.SmartContract.c] 99.32%[test/AElf.Sdk.CSharp.Tests/AElf.Sdk.CSharp.Tests.csproj] |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3630 +/- ##
===========================================
- Coverage 90.53% 73.56% -16.97%
===========================================
Files 677 678 +1
Lines 26104 26226 +122
Branches 2353 2358 +5
===========================================
- Hits 23634 19294 -4340
- Misses 2355 6779 +4424
- Partials 115 153 +38
Flags with carried forward coverage won't be shown. Click here to find out more.
|
loning
reviewed
Dec 24, 2024
| @@ -200,6 +200,12 @@ private void WhitelistAElfTypes(Whitelist whitelist) | |||
| // Selectively allowed types and members | |||
| .Namespace("AElf.Cryptography.SecretSharing", Permission.Denied, type => type | |||
| .Type(typeof(SecretSharingHelper), Permission.Denied, member => member | |||
| .Member(nameof(SecretSharingHelper.DecodeSecret), Permission.Allowed))); | |||
| .Member(nameof(SecretSharingHelper.DecodeSecret), Permission.Allowed) | |||
| .Member(nameof(SecretSharingHelper.Ed25519Verify), Permission.Allowed) | |||
There was a problem hiding this comment.
add a new helper,not SecretSharingHelper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Issue: #3612
For issue #3619
For issue #3610