Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: account provided but no password, prompt user for password #96

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

AbigailDeng
Copy link
Collaborator

No description provided.

Copy link

vizipi bot commented Dec 3, 2024

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
33.33% aelf-lxy 2 1
33.33% yongenaelf 2 1
33.33% eanzhao 1 1

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
src/utils/constants.js71.43%5 out of 7 times
src/utils/utils.js42.86%3 out of 7 times
src/index.js42.86%3 out of 7 times
README.md42.86%3 out of 7 times

Committed file ranks

(click to expand)
  • 94.32%[src/command/call.js]
  • 99.43%[package.json]
  • 86.36%[test/command/call.test.js]
  • 1 similar comment
    Copy link

    vizipi bot commented Dec 3, 2024

    Pull request analysis by VIZIPI

    Below you will find who is the most qualified team member to review your code.
    This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

    Reviewers with knowledge related to these changes

    Match % Person Commit Count Common Files
    33.33% aelf-lxy 2 1
    33.33% yongenaelf 2 1
    33.33% eanzhao 1 1

    Potential missing files from this Pull request

    files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
    FilePercentilerate
    src/utils/constants.js71.43%5 out of 7 times
    src/utils/utils.js42.86%3 out of 7 times
    src/index.js42.86%3 out of 7 times
    README.md42.86%3 out of 7 times

    Committed file ranks

    (click to expand)
  • 94.32%[src/command/call.js]
  • 99.43%[package.json]
  • 86.36%[test/command/call.test.js]
  • @AbigailDeng AbigailDeng linked an issue Dec 4, 2024 that may be closed by this pull request
    Copy link

    github-actions bot commented Dec 4, 2024

    Total coverage

    Lines Branches Functions Statements
    95.91% (+0.01%) 89.05% (+0.05%) 97.59% (+0.00%) 95.76% (+0.01%)

    Detailed report

    click to open the diff coverage report
    File Lines Branches Functions Statements
    /home/runner/work/aelf-command/aelf-command/src/command/call.js 98.24% (+0.10%) 89.18% (+0.61%) 100.00% 98.27% (+0.09%)

    @hzz780 hzz780 merged commit 38198e4 into master Dec 4, 2024
    2 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    aelf-command - only account is provided
    2 participants