Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Added aelf-samples submodule #52

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Feature: Added aelf-samples submodule #52

wants to merge 5 commits into from

Conversation

vasmohi
Copy link
Collaborator

@vasmohi vasmohi commented Sep 27, 2024

  • Added aelf-samples submodule to aelf-developer-tools
  • Added Todo, TicTacToe & ExpenseTracker smart contract templates to aelf-developer-tools

@vizipi Vizipi
Copy link

vizipi bot commented Sep 27, 2024

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
2.50% yimeng.lu 17 1
2.50% zhifenglee-portkey 9 1

Potential missing files from this Pull request

No commonly committed files found with a 40% threashold

Committed file ranks

(click to expand)
  • 0.00%[templates/TicTacToeContract/test/TicTacToe.Tests.csproj]
  • 0.00%[templates/ToDoContract/src/ToDo.csproj]
  • 0.00%[templates/ExpenseTrackerContract/src/.DS_Store]
  • 0.00%[templates/TicTacToeContract/src/TicTacToe.csproj]
  • 0.00%[templates/ExpenseTrackerContract/src/ExpenseTrackerState.cs]
  • 0.00%[templates/ExpenseTrackerContract/.DS_Store]
  • 0.00%[...templates/ExpenseTrackerContract/test/ExpenseTrackerTests]
  • 0.00%[...templates/ToDoContract/test/Protobuf/stub/hello_world_con]
  • 0.00%[...templates/TicTacToeContract/src/Protobuf/contract/hello_w]
  • 0.00%[templates/ToDoContract/test/_Setup.cs]

    • zhifenglee-aelf
    zhifenglee-aelf requested changes Oct 22, 2024
    View reviewed changes
    .github/workflows/publish-aelf-samples-prod.yml Outdated
    on:
    push:
    tags:
    - 'aelf-samples-v*'
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This file should not exists. Basically when someone puts up a template tag with version, it should also pack all aelf-samples contract into the contract template package.

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Removed prod-workflow

    templates/AElf.Contract.Template.csproj
    @@ -20,6 +20,9 @@
    <Content Include="LotteryGameContract\**\*" Exclude="LotteryGameContract\**\bin\**;LotteryGameContract\**\obj\**" />
    <Content Include="SimpleDAOContract\**\*" Exclude="SimpleDAOContract\**\bin\**;SimpleDAOContract\**\obj\**" />
    <Content Include="NftSaleContract\**\*" Exclude="NftSaleContract\**\bin\**;NftSaleContract\**\obj\**" />
    <Content Include="ToDoContract\**\*" Exclude="ToDoContract\**\bin\**;ToDoContract\**\obj\**" />
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    These should be removed and instead be read from the aelf-sample submodule

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Configured to fetch from aelf-samples

    templates/ExpenseTrackerContract/.template.config/template.json
    @@ -0,0 +1,21 @@
    {
    "$schema": "http://json.schemastore.org/template",
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    All these should be added into aelf-samples repo to maintain consistency

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Added to aelf-samples

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @zhifenglee-aelf zhifenglee-aelf zhifenglee-aelf approved these changes

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @vasmohi @zhifenglee-aelf