Feature/advance nft #358
Open
Feature/advance nft #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1d67d68.
|
Pull request analysis by VIZIPI Below you will find who is the most qualified team member to review your code. Reviewers with knowledge related to these changes
Potential missing files from this Pull requestfiles commonly committed with a subset of this pr, but not committed this time. (click to collapse)
Committed file ranks |
yongenaelf
reviewed
Jan 2, 2025
| Please remember to export PATH after installing aelf.deploy. | ||
|
|
||
| :::info | ||
| ℹ️ Note: If you have installed aelf.deploy and your terminal says that there is no such command available, please uninstall and install aelf.deploy. |
There was a problem hiding this comment.
Suggested change
| ℹ️ Note: If you have installed aelf.deploy and your terminal says that there is no such command available, please uninstall and install aelf.deploy. | |
| ℹ️ Note: If you have installed aelf.deploy and your terminal says that there is no such command available, please uninstall and reinstall aelf.deploy. |
yongenaelf
reviewed
Jan 2, 2025
| 2. Download the development template by entering your project name. | ||
|  | ||
| 3. Unzip the downloaded file to extract the project files. | ||
| 4. After unzipping, you are ready to start development |
There was a problem hiding this comment.
Suggested change
| 4. After unzipping, you are ready to start development | |
| 4. After unzipping the files, you are ready to start development. |
yongenaelf
reviewed
Jan 2, 2025
| Select `Codespaces`. | ||
| 5. Click on the `+` sign to create a new Codespace. | ||
| 6. After some time, your workspace will load with the contents of the repository. | ||
| You can now continue your development using GitHub Codespaces. |
There was a problem hiding this comment.
Suggested change
| You can now continue your development using GitHub Codespaces. | |
| You may now continue your development using GitHub Codespaces. |
yongenaelf
reviewed
Jan 2, 2025
Comment on lines
+63
to
+72
| NFTAeIndexer/ | ||
| ├── Contracts/ # Contract interfaces | ||
| │ ├── TokenContract.c.cs | ||
| │ ├── TokenContract.g.cs | ||
| ├── Entities/ # Data models | ||
| │ ├── Account.cs # NFT account information | ||
| │ └── TransferRecord.cs # NFT transfer records | ||
| ├── Processors/ # Event processors | ||
| │ └── NFTTransferredProcessor.cs # Handles NFT transfer events | ||
| └── GraphQL/ # GraphQL query definitions |
There was a problem hiding this comment.
yongenaelf
reviewed
Jan 2, 2025
| ``` | ||
|
|
||
| :::tip | ||
| ℹ️ Note: If other contract files are needed, they need to be generated by compiling the corresponding contract project! |
There was a problem hiding this comment.
any step-by-step instructions on how to do this?
yongenaelf
reviewed
Jan 2, 2025
|
|
||
| - Replace the existing **`fetchContract`** function with this updated code: | ||
|
|
||
| ```javascript title="useNFTSmartContract.ts" |
yongenaelf
reviewed
Jan 2, 2025
|
|
||
| - Replace the existing **`useEffect`** hook with this updated code: | ||
|
|
||
| ```javascript title="useNFTSmartContract.ts" |
yongenaelf
reviewed
Jan 2, 2025
|
|
||
| - Replace the existing connect function with this code snippet: | ||
|
|
||
| ```javascript title="header/index.tsx" |
yongenaelf
reviewed
Jan 2, 2025
|
|
||
| - Replace the existing **`fetchUserNftData`** function with this code snippet: | ||
|
|
||
| ```javascript title="commonFunctions.ts" |
yongenaelf
reviewed
Jan 2, 2025
|
|
||
| ```javascript title="commonFunctions.ts" | ||
| // fetch NFT Data from Indexer API | ||
| export const fetchUserNftData = async (addres:string) => { |
There was a problem hiding this comment.
Suggested change
| export const fetchUserNftData = async (addres:string) => { | |
| export const fetchUserNftData = async (address:string) => { |
yongenaelf
reviewed
Jan 2, 2025
| const body = JSON.stringify({ | ||
| query: ` | ||
| query { | ||
| account(input: { chainId: "tDVW", address: "${addres}" }) { |
There was a problem hiding this comment.
Suggested change
| account(input: { chainId: "tDVW", address: "${addres}" }) { | |
| account(input: { chainId: "tDVW", address: "${address}" }) { |
yongenaelf
reviewed
Jan 2, 2025
|
|
||
| - Replace the existing **`getNFTData`** function with this code snippet: | ||
|
|
||
| ```javascript title="home/index.tsx" |
yongenaelf
reviewed
Jan 2, 2025
|
|
||
| - Replace the existing **`getNFTData`** function with this code snippet: | ||
|
|
||
| ```javascript title="profile/index.tsx" |
yongenaelf
reviewed
Jan 2, 2025
|
|
||
| - Replace the existing **`createNftCollectionOnMainChain`** function with this code snippet: | ||
|
|
||
| ```javascript title="create-nft/index.tsx" |
yongenaelf
reviewed
Jan 2, 2025
| createLoadingId = toast.loading("Creating NFT Collection.."); | ||
|
|
||
| // Create an object with the necessary information for the new NFT collection. | ||
| const createNtfInput: INftInput = { |
There was a problem hiding this comment.
Suggested change
| const createNtfInput: INftInput = { | |
| const createNftInput: INftInput = { |
yongenaelf
reviewed
Jan 2, 2025
| const result = await mainChainSmartContract?.callSendMethod( | ||
| "Create", | ||
| currentWalletAddress, | ||
| createNtfInput |
There was a problem hiding this comment.
Suggested change
| createNtfInput | |
| createNftInput |
yongenaelf
reviewed
Jan 2, 2025
| removeNotification(createLoadingId); | ||
|
|
||
| // Return the input data for further use. | ||
| return createNtfInput; |
There was a problem hiding this comment.
Suggested change
| return createNtfInput; | |
| return createNftInput; |
yongenaelf
reviewed
Jan 2, 2025
|
|
||
| - Replace the existing **`validateNftCollectionInfo`** function with this code snippet: | ||
|
|
||
| ```javascript title="create-nft/index.tsx" |
yongenaelf
reviewed
Jan 2, 2025
Comment on lines
+125
to
+132
| while (!heightDone) { | ||
| // Get the latest index height | ||
| const sideIndexMainHeight = await GetParentChainHeight(); | ||
| if (Number(sideIndexMainHeight) >= VALIDATE_TXRESULT.Transaction.RefBlockNumber) { | ||
| VALIDATE_TXRESULT = await aelf.chain.getTxResult(VALIDATE_TXID); | ||
| heightDone = true; | ||
| } | ||
| } |
There was a problem hiding this comment.
you should have some logic to throttle this, like to wait a few seconds between calls.
yongenaelf
reviewed
Jan 2, 2025
|
|
||
| - Replace the existing **`GetParentChainHeight`** function with the following code snippet: | ||
|
|
||
| ```javascript title="create-nft/index.tsx" |
yongenaelf
reviewed
Jan 2, 2025
|
|
||
| - Replace the existing **`getMerklePathByTxId`** function with this code snippet: | ||
|
|
||
| ```javascript title="create-nft/index.tsx" |
yongenaelf
reviewed
Jan 2, 2025
|
|
||
| - Replace the existing **`createCollectionOnSideChain`** function with this code snippet: | ||
|
|
||
| ```javascript title="create-nft/index.tsx" |
yongenaelf
reviewed
Jan 2, 2025
| let crossChainLoadingId; | ||
| try { | ||
| crossChainLoadingId = toast.loading( | ||
| "Creating Collection on SideChain..." |
There was a problem hiding this comment.
Suggested change
| "Creating Collection on SideChain..." | |
| "Creating Collection on dAppChain..." |
yongenaelf
reviewed
Jan 2, 2025
| const CROSS_CHAIN_CREATE_TOKEN_PARAMS = { | ||
| fromChainId: mainchain_from_chain_id, | ||
| parentChainHeight: "" + BlockNumber, | ||
| // @ts-ignore |
yongenaelf
reviewed
Jan 2, 2025
| done = true; | ||
| setIsNftCollectionCreated(true); | ||
| toast.update(crossChainLoadingId, { | ||
| render: "Collection was Created Successfully On SideChain", |
There was a problem hiding this comment.
Suggested change
| render: "Collection was Created Successfully On SideChain", | |
| render: "Collection was Created Successfully On dAppChain", |
yongenaelf
reviewed
Jan 2, 2025
Comment on lines
+281
to
+282
| if ((err as { Error: string }).Error.includes("Cross chain verification failed.")) { | ||
| console.log("Exit."); |
There was a problem hiding this comment.
what should the user do to fix this?
yongenaelf
reviewed
Jan 2, 2025
|
|
||
| 2. Replace the form variable with this code snippet: | ||
|
|
||
| ```javascript title="create-nft/index.tsx" |
yongenaelf
reviewed
Jan 2, 2025
| ``` | ||
|
|
||
| #### Here's what the function does: | ||
| 1. Initializes a new form variable with default values needed to create a nft. |
There was a problem hiding this comment.
Suggested change
| 1. Initializes a new form variable with default values needed to create a nft. | |
| 1. Initializes a new form variable with default values needed to create an NFT. |
yongenaelf
reviewed
Jan 2, 2025
| @@ -0,0 +1,48 @@ | |||
| ### Configure Submit Form | |||
| Now, let's Write a Function to Call Necessary Functions for NFT Creation. | |||
There was a problem hiding this comment.
Suggested change
| Now, let's Write a Function to Call Necessary Functions for NFT Creation. | |
| Now, let's write a function to call necessary functions for NFT creation. |
yongenaelf
reviewed
Jan 2, 2025
|
|
||
| 2. Replace the existing **`onSubmit`** function with this code snippet: | ||
|
|
||
| ```javascript title="create-nft/index.tsx" |
yongenaelf
reviewed
Jan 2, 2025
| @@ -0,0 +1,311 @@ | |||
| ### Create NFT Token | |||
| **Step 1: Write a Function to create NFTs on the mainchain** | |||
There was a problem hiding this comment.
Suggested change
| **Step 1: Write a Function to create NFTs on the mainchain** | |
| **Step 1: Write a function to create NFTs on the MainChain** |
yongenaelf
reviewed
Jan 2, 2025
| @@ -0,0 +1,311 @@ | |||
| ### Create NFT Token | |||
| **Step 1: Write a Function to create NFTs on the mainchain** | |||
| Now, let's write the create NFTs on mainchain function. | |||
There was a problem hiding this comment.
Suggested change
| Now, let's write the create NFTs on mainchain function. | |
| Now, let's write the **create NFTs on MainChain** function. |
yongenaelf
reviewed
Jan 2, 2025
|
|
||
| 2. Replace the existing **`createNFTOnMainChain`** function with this code snippet: | ||
|
|
||
| ```javascript title="create-nft/index.tsx" |
yongenaelf
reviewed
Jan 2, 2025
| ); | ||
|
|
||
| // Preparing Parameter for Create Function | ||
| const createNtfMainChainInput = { |
There was a problem hiding this comment.
Suggested change
| const createNtfMainChainInput = { | |
| const createNftMainChainInput = { |
yongenaelf
reviewed
Jan 2, 2025
| const resultMainchain = await mainChainSmartContract?.callSendMethod( | ||
| "Create", | ||
| currentWalletAddress, | ||
| createNtfMainChainInput |
There was a problem hiding this comment.
Suggested change
| createNtfMainChainInput | |
| createNftMainChainInput |
yongenaelf
reviewed
Jan 2, 2025
|
|
||
| 2. Replace the existing **`validateNftToken`** function with this code snippet: | ||
|
|
||
| ```javascript title="create-nft/index.tsx" |
yongenaelf
reviewed
Jan 2, 2025
Comment on lines
+115
to
+125
| while (!heightDone) { | ||
| // get latest index Hight | ||
| const sideIndexMainHeight = await GetParentChainHeight(); | ||
| if ( | ||
| // check the latest index Hight is grater than or equal | ||
| Number(sideIndexMainHeight) >= VALIDATE_TXRESULT.Transaction.RefBlockNumber | ||
| ) { | ||
| VALIDATE_TXRESULT = await aelf.chain.getTxResult(VALIDATE_TXID); | ||
| heightDone = true; | ||
| } | ||
| } |
There was a problem hiding this comment.
throttle this loop by adding a delay between each call
yongenaelf
reviewed
Jan 2, 2025
|
|
||
| 2. Replace the existing **`createNftTokenOnSideChain`** function with this code snippet: | ||
|
|
||
| ```javascript title="create-nft/index.tsx" |
yongenaelf
reviewed
Jan 2, 2025
|
|
||
| 2. Replace the existing **`issueNftOnSideChain`** function with this code snippet: | ||
|
|
||
| ```javascript title="create-nft/index.tsx" |
yongenaelf
reviewed
Jan 2, 2025
|
|
||
| 2. Replace the existing **`createNftToken`** function with this code snippet: | ||
|
|
||
| ```javascript title="create-nft/index.tsx" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.