Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support querying with Terms syntax #36

Merged
merged 15 commits into from
Oct 22, 2024
Merged

Feature: Support querying with Terms syntax #36

merged 15 commits into from
Oct 22, 2024

Conversation

AElfBourneShi
Copy link
Collaborator

close #35

Copy link

vizipi bot commented Oct 16, 2024

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
75.00% ZhangXin 11 3
75.00% fengyan2023 2 3
50.00% louis.li 1 2

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
...src/AElf.EntityMapping.Elasticsearch/Linq/ElasticGenerato50.00%3 out of 6 times
...src/AElf.EntityMapping.Elasticsearch/ElasticsearchCollect50.00%3 out of 6 times
...test/AElf.EntityMapping.Elasticsearch.Tests/Elasticsearch50.00%3 out of 6 times
...src/AElf.EntityMapping.Elasticsearch/Services/IElasticInd50.00%3 out of 6 times
...src/AElf.EntityMapping.Elasticsearch/Services/EnsureIndex50.00%3 out of 6 times
...test/AElf.EntityMapping.Elasticsearch.Tests/Entities/Bloc50.00%3 out of 6 times
...src/AElf.EntityMapping.Elasticsearch/Linq/QueryModelExten50.00%3 out of 6 times
...test/AElf.EntityMapping.Elasticsearch.Tests/Entities/Bloc50.00%3 out of 6 times
...src/AElf.EntityMapping/Repositories/IEntityMappingBasicRe50.00%3 out of 6 times
...test/AElf.EntityMapping.Elasticsearch.Tests/Entities/LogE50.00%3 out of 6 times

Committed file ranks

(click to expand)
  • 55.48%[...src/AElf.EntityMapping.Elasticsearch/ElasticsearchRespons]
  • 95.21%[...test/AElf.EntityMapping.Elasticsearch.Tests/Repositories/]
  • 80.14%[...src/AElf.EntityMapping.Elasticsearch/Linq/GeneratorExpres]
  • 80.14%[...src/AElf.EntityMapping.Elasticsearch/IElasticsearchClient]
  • Copy link

    codecov bot commented Oct 16, 2024

    Codecov Report

    Attention: Patch coverage is 40.00000% with 9 lines in your changes missing coverage. Please review.

    Project coverage is 77.12%. Comparing base (eb3add5) to head (f582f0c).
    Report is 1 commits behind head on dev.

    Files with missing lines Patch % Lines
    ...pping.Elasticsearch/ElasticsearchResponseHelper.cs 10.00% 6 Missing and 3 partials ⚠️
    Additional details and impacted files

    Impacted file tree graph

    @@            Coverage Diff             @@
    ##              dev      #36      +/-   ##
    ==========================================
    + Coverage   76.99%   77.12%   +0.12%     
    ==========================================
      Files          30       30              
      Lines        1343     1355      +12     
      Branches      157      159       +2     
    ==========================================
    + Hits         1034     1045      +11     
    - Misses        229      230       +1     
      Partials       80       80              
    Flag Coverage Δ
    ?

    Flags with carried forward coverage won't be shown. Click here to find out more.

    Files with missing lines Coverage Δ
    ...ping.Elasticsearch/IElasticsearchClientProvider.cs 100.00% <ø> (ø)
    ...ng.Elasticsearch/IElasticsearchQueryableFactory.cs 100.00% <100.00%> (ø)
    ...ping.Elasticsearch/Options/ElasticsearchOptions.cs 100.00% <100.00%> (ø)
    ...pping.Elasticsearch/ElasticsearchResponseHelper.cs 25.00% <10.00%> (-41.67%) ⬇️

    ... and 3 files with indirect coverage changes

    @jason-aelf jason-aelf changed the title [WIP]Feature: Support querying with Terms syntax Feature: Support querying with Terms syntax Oct 22, 2024
    @jason-aelf jason-aelf merged commit afe3b7b into dev Oct 22, 2024
    5 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants